mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

Handle the "switchannotationeditorparams" event in the editor-code (issue 18196)

Browse source 
The problem seems to be caused by the browser trying to "restore" editing input-elements, in the various toolbars, to their previous values when the tab is re-opened.

Hence the simplest solution appears to be to move the event handling into the editor-code, which is also less code overall, since the listener thus won't be registered early enough for the problem to appear.
This commit is contained in:
Jonas Jenwald 2024-08-13 15:23:23 +02:00
parent 82735537bf
commit 9e0c6ef476
3 changed files with 5 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

5
web/app.js
View file

@ -1939,11 +1939,6 @@ const PDFViewerApplication = {
evt => (pdfViewer.annotationEditorMode = evt),
{ signal }
);
eventBus._on(
"switchannotationeditorparams",
evt => (pdfViewer.annotationEditorParams = evt),
{ signal }
);
eventBus._on("print", this.triggerPrinting.bind(this), { signal });
eventBus._on("download", this.downloadOrSave.bind(this), { signal });
eventBus._on("firstpage", () => (this.page = 1), { signal });

8
web/pdf_viewer.js
View file

@ -2363,14 +2363,6 @@ class PDFViewer {
updater();
}
// eslint-disable-next-line accessor-pairs
set annotationEditorParams({ type, value }) {
if (!this.#annotationEditorUIManager) {
throw new Error(`The AnnotationEditor is not enabled.`);
}
this.#annotationEditorUIManager.updateParams(type, value);
}
refresh(noUpdate = false, updateArgs = Object.create(null)) {
if (!this.pdfDocument) {
return;