mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-11 19:58:15 +02:00
Implement reproducibility for the JSDoc builds
The JSDoc builds are currently not reproducible because a timestamp is included in the output, meaning that two builds from identical source code, made at different times, result in different output. This is undesirable because it makes diffing the output difficult, for instance recently during the Gulp 5 efforts, because the timestamp differences are irrelevant and could obscure actually important differences in the output during e.g. code changes. Moreover, reprodicibility of build artifacts has become increasingly important; please refer to the Reproducible Builds initiative at https://reproducible-builds.org (note the "Why does it matter?" section specifically) and https://reproducible-builds.org/docs/timestamps which further explains the problem of timestamps in build artifacts. This commit fixes the issue by configuring JSDoc to not include the timestamps in the output. It's not relevant for end users and without it the build is fully reproducible so that identical source code builds result in bit-by-bit identical output artifacts. Note that this option sadly can only be set via a configuration file, and not via the command line parameters like we used to have, so for consistency we also move the other options into the configuration file so they are all in one place and the Gulpfile becomes a bit simpler.
This commit is contained in:
parent
f8acd33527
commit
9d0002555d
2 changed files with 14 additions and 9 deletions
10
gulpfile.mjs
10
gulpfile.mjs
|
@ -1526,18 +1526,10 @@ gulp.task("jsdoc", function (done) {
|
|||
console.log();
|
||||
console.log("### Generating documentation (JSDoc)");
|
||||
|
||||
const JSDOC_FILES = ["src/display/api.js"];
|
||||
|
||||
fs.rmSync(JSDOC_BUILD_DIR, { recursive: true, force: true });
|
||||
fs.mkdirSync(JSDOC_BUILD_DIR, { recursive: true });
|
||||
|
||||
const command =
|
||||
'"node_modules/.bin/jsdoc" -d ' +
|
||||
JSDOC_BUILD_DIR +
|
||||
" " +
|
||||
JSDOC_FILES.join(" ");
|
||||
|
||||
exec(command, done);
|
||||
exec('"node_modules/.bin/jsdoc" -c jsdoc.json', done);
|
||||
});
|
||||
|
||||
gulp.task("types", function (done) {
|
||||
|
|
13
jsdoc.json
Normal file
13
jsdoc.json
Normal file
|
@ -0,0 +1,13 @@
|
|||
{
|
||||
"source": {
|
||||
"include": ["src/display/api.js"]
|
||||
},
|
||||
"opts": {
|
||||
"destination": "build/jsdoc/"
|
||||
},
|
||||
"templates": {
|
||||
"default": {
|
||||
"includeDate": false
|
||||
}
|
||||
}
|
||||
}
|
Loading…
Add table
Reference in a new issue