mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-25 17:48:07 +02:00
Code Activity

Remove the isString helper function

Browse source 
The call-sites are replaced by direct `typeof`-checks instead, which removes unnecessary function calls. Note that in the `src/`-folder we already had more `typeof`-cases than `isString`-calls.
This commit is contained in:
Jonas Jenwald 2022-02-23 17:02:19 +01:00
parent 6bd4e0f5af
commit 99cd24ce3e
9 changed files with 47 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/core/cmap.js
View file

@ -16,7 +16,6 @@
import {
CMapCompressionType,
FormatError,
isString,
unreachable,
warn,
} from "../shared/util.js";
@ -767,7 +766,7 @@ const CMapFactory = (function CMapFactoryClosure() {
}
function expectString(obj) {
if (!isString(obj)) {
if (typeof obj !== "string") {
throw new FormatError("Malformed CMap: expected string.");
}
}
@ -812,7 +811,7 @@ const CMapFactory = (function CMapFactoryClosure() {
expectString(obj);
const high = strToInt(obj);
obj = lexer.getObj();
if (Number.isInteger(obj) || isString(obj)) {
if (Number.isInteger(obj) || typeof obj === "string") {
const dstLow = Number.isInteger(obj) ? String.fromCharCode(obj) : obj;
cMap.mapBfRange(low, high, dstLow);
} else if (isCmd(obj, "[")) {
@ -878,12 +877,12 @@ const CMapFactory = (function CMapFactoryClosure() {
if (isCmd(obj, "endcodespacerange")) {
return;
}
if (!isString(obj)) {
if (typeof obj !== "string") {
break;
}
const low = strToInt(obj);
obj = lexer.getObj();
if (!isString(obj)) {
if (typeof obj !== "string") {
break;
}
const high = strToInt(obj);