mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 08:08:07 +02:00
Code Activity

[Regression] Ensure that "Highlight All" is propagated to all pages for 'findagain' events where the findbar was previously closed (PR 10100 follow-up)

Browse source 
**STR:**
1. Open the default viewer, with the `tracemonkey` file.
2. Open the findbar, and search for "trace".
3. Enable the "Highlight All" option.
4. Close the findbar.
5. Re-open the findbar, and click on the "findNext" button.
6. Scroll down to the *second* page of the document.

**ER:**
Since "Highlight All" is active, all matches on the *second* page should be highlighted.

**AR:**
No matches are highlighted on the *second* page.
This commit is contained in:
Jonas Jenwald 2018-10-29 16:15:28 +01:00
parent 991a574c60
commit 96abb4bbe7
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
web/pdf_find_controller.js
View file

@ -139,6 +139,16 @@ class PDFFindController {
this._nextMatch();
this._findTimeout = null;
}, FIND_TIMEOUT);
} else if (cmd === 'findagain' && !this._dirtyMatch) {
const updateHighlightAll = (!this._highlightMatches &&
this._state.highlightAll);
this._nextMatch();
// When the findbar was previously closed, and `highlightAll` is set,
// ensure that the matches on all active pages are highlighted again.
if (updateHighlightAll) {
this._updateAllPages();
}
} else {
this._nextMatch();
}