mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

[Editor] Remove useless and potentially deleted editors

Browse source 
After a deletion, a reference on a deleted editor can still be used
(for example in changing the font size just after having deleted all
editors).
This commit is contained in:
Calixte Denizet 2022-07-19 23:04:26 +02:00
parent f46895d750
commit 964fb77fa5
1 changed files with 3 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/display/editor/tools.js
View file

@ -786,6 +786,7 @@ class AnnotationEditorUIManager {
delete() {
let cmd, undo;
if (this.#isAllSelected) {
this.#previousActiveEditor = this.#activeEditor = null;
const editors = Array.from(this.#allEditors.values());
cmd = () => {
for (const editor of editors) {
@ -807,6 +808,7 @@ class AnnotationEditorUIManager {
return;
}
const editor = this.#activeEditor;
this.#previousActiveEditor = this.#activeEditor = null;
cmd = () => {
editor.remove();
};
@ -834,15 +836,7 @@ class AnnotationEditorUIManager {
cut() {
if (this.#activeEditor) {
this.#clipboardManager.copy(this.#activeEditor);
const editor = this.#activeEditor;
const cmd = () => {
editor.remove();
};
const undo = () => {
this.#addEditorToLayer(editor);
};
this.addCommands({ cmd, undo, mustExec: true });
this.delete();
}
}