mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Enable the ESLint no-useless-escape rule (PR 12551 follow-up)

Browse source 
Note that a number of these cases are covered by existing unit-tests, and a few others only matter for the development/build scripts.
Furthermore, I've also tried to the best of my ability to test each case *manually* to hopefully further reduce the likelihood of this patch introducing any bugs.

Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-useless-escape
This commit is contained in:
Jonas Jenwald 2020-11-07 12:59:53 +01:00
parent e3851a6765
commit 9602844368
9 changed files with 11 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/scripting_api/util.js
View file

@ -61,7 +61,7 @@ class Util extends PDFObject {
throw new TypeError("First argument of printf must be a string");
}
const pattern = /%(,[0-4])?([\+ 0#]+)?([0-9]+)?(\.[0-9]+)?(.)/g;
const pattern = /%(,[0-4])?([+ 0#]+)?([0-9]+)?(\.[0-9]+)?(.)/g;
const PLUS = 1;
const SPACE = 2;
const ZERO = 4;

2
src/shared/util.js
View file

@ -824,7 +824,7 @@ function escapeString(str) {
// replace "(", ")", "\n", "\r" and "\"
// by "\(", "\)", "\\n", "\\r" and "\\"
// in order to write it in a PDF file.
return str.replace(/([\(\)\\\n\r])/g, match => {
return str.replace(/([()\\\n\r])/g, match => {
if (match === "\n") {
return "\\n";
} else if (match === "\r") {