mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-26 10:08:06 +02:00
Code Activity

Update packages

Browse source 
Jasmine had a major version bump and required a few minor changes in our
booting code. Most notably, using `pending` in a `describe` block is no
longer supported, so we can only return early there. On the positive
side, the unit tests now run in a random order by default, which
eliminates any dependencies between unit tests.

Note that upgrading to Webpack 4 is out of scope for this patch since
the bots cannot work well with the newly generated bundles (both
browsers on both bots do not react within 120 seconds). Webpack 4 is not
faster for us than Webpack 3, so for now there is no need to upgrade.
This commit is contained in:
Tim van der Meij 2018-03-17 19:56:39 +01:00
parent db6e316efd
commit 95de23e6e3
No known key found for this signature in database
GPG key ID: 8C3FD2925A5F2762
6 changed files with 61 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

11
test/unit/jasmine-boot.js
View file

@ -124,9 +124,9 @@ function initializePDFJS(callback) {
},
});
var catchingExceptions = queryString.getParam('catch');
env.catchExceptions(typeof catchingExceptions === 'undefined' ?
true : catchingExceptions);
var stoppingOnSpecFailure = queryString.getParam('failFast');
env.stopOnSpecFailure(typeof stoppingOnSpecFailure === 'undefined' ?
false : stoppingOnSpecFailure);
var throwingExpectationFailures = queryString.getParam('throwFailures');
env.throwOnExpectationFailure(throwingExpectationFailures);
@ -142,8 +142,9 @@ function initializePDFJS(callback) {
// Reporters
var htmlReporter = new jasmine.HtmlReporter({
env,
onRaiseExceptionsClick() {
queryString.navigateWithNewParam('catch', !env.catchingExceptions());
onStopExecutionClick() {
queryString.navigateWithNewParam('failFast',
env.stoppingOnSpecFailure());
},
onThrowExpectationsClick() {
queryString.navigateWithNewParam('throwFailures',