mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-26 10:08:06 +02:00
Code Activity

XFA - Elements created outside of XML must have all their properties (bug 1722029)

Browse source 
- an Image element was created, attached to its parent but the $globalData property was not set and that led to an error.
  - the pdf in bug 1722029 has 27 rendered rows (checked in Acrobat) when only one was displayed: this patch some binding issues around the occur element.
This commit is contained in:
Calixte Denizet 2021-07-26 16:14:46 +02:00
parent 777d890268
commit 959120e6c9
5 changed files with 98 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

66
src/core/xfa/template.js
View file

@ -3603,25 +3603,60 @@ class Occur extends XFAObject {
constructor(attributes) {
super(TEMPLATE_NS_ID, "occur", /* hasChildren = */ true);
this.id = attributes.id || "";
this.initial = getInteger({
data: attributes.initial,
defaultValue: 1,
validate: x => true,
});
this.max = getInteger({
data: attributes.max,
defaultValue: 1,
validate: x => true,
});
this.min = getInteger({
data: attributes.min,
defaultValue: 1,
validate: x => true,
});
this.initial =
attributes.initial !== ""
? getInteger({
data: attributes.initial,
defaultValue: "",
validate: x => true,
})
: "";
this.max =
attributes.max !== ""
? getInteger({
data: attributes.max,
defaultValue: 1,
validate: x => true,
})
: "";
this.min =
attributes.min !== ""
? getInteger({
data: attributes.min,
defaultValue: 1,
validate: x => true,
})
: "";
this.use = attributes.use || "";
this.usehref = attributes.usehref || "";
this.extras = null;
}
[$clean]() {
const parent = this[$getParent]();
const originalMin = this.min;
if (this.min === "") {
this.min =
parent instanceof PageArea || parent instanceof PageSet ? 0 : 1;
}
if (this.max === "") {
if (originalMin === "") {
this.max =
parent instanceof PageArea || parent instanceof PageSet ? -1 : 1;
} else {
this.max = this.min;
}
}
if (this.max !== -1 && this.max < this.min) {
this.max = this.min;
}
if (this.initial === "") {
this.initial = parent instanceof Template ? 1 : this.min;
}
}
}
class Oid extends StringObject {
@ -5705,6 +5740,7 @@ class Value extends XFAObject {
if (parent.ui && parent.ui.imageEdit) {
if (!this.image) {
this.image = new Image({});
this[$appendChild](this.image);
}
this.image[$content] = value[$content];
return;