From ec1a05c1045215b33bd62a7f49ba59a071babf43 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 21 Dec 2024 14:15:28 +0100 Subject: [PATCH] Add missing `startWorkerTask` calls in the "SaveDocument" handler Without these calls we'll not actually wait for saving to complete when document destruction runs; compare with other `WorkerTask`-usage in this file. While I cannot imagine that this has caused any problems for library users, the code is however not technically correct as-is. --- src/core/worker.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/core/worker.js b/src/core/worker.js index ecd0c52c0..7ae22ee45 100644 --- a/src/core/worker.js +++ b/src/core/worker.js @@ -177,6 +177,7 @@ class WorkerMessageHandler { if (isPureXfa) { const task = new WorkerTask("loadXfaFonts"); startWorkerTask(task); + await Promise.all([ pdfManager .loadXfaFonts(handler, task) @@ -590,6 +591,8 @@ class WorkerMessageHandler { newAnnotationPromises.push( pdfManager.getPage(pageIndex).then(page => { const task = new WorkerTask(`Save (editor): page ${pageIndex}`); + startWorkerTask(task); + return page .saveNewAnnotations( handler, @@ -637,6 +640,8 @@ class WorkerMessageHandler { promises.push( pdfManager.getPage(pageIndex).then(function (page) { const task = new WorkerTask(`Save: page ${pageIndex}`); + startWorkerTask(task); + return page .save(handler, task, annotationStorage, changes) .finally(function () {