From c08b09d3b95d63efe80e60781c63fe6c50f71863 Mon Sep 17 00:00:00 2001
From: Tim van der Meij <timvandermeij@gmail.com>
Date: Tue, 16 Apr 2024 16:24:24 +0200
Subject: [PATCH] Fix `JpxImage` API issues (PR 17946 follow-up)

This commit changes the `JpxImage.decode` method signature to define the
`ignoreColorSpace` argument as optional with a default value. Note that
we already set this default value in the `getBytes` method of the
`src/core/decode_stream.js` file since this option only seems useful for
certain special cases and therefore shouldn't be mandatory to provide.

Moreover, the JPX fuzzer is changed to use the new `JpxImage` API.
---
 src/core/jpx.js             | 2 +-
 test/fuzz/jpx_image.fuzz.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/core/jpx.js b/src/core/jpx.js
index 81a1478dc..4f55f479c 100644
--- a/src/core/jpx.js
+++ b/src/core/jpx.js
@@ -25,7 +25,7 @@ class JpxError extends BaseException {
 class JpxImage {
   static #module = null;
 
-  static decode(data, ignoreColorSpace) {
+  static decode(data, ignoreColorSpace = false) {
     this.#module ||= OpenJPEG();
     const imageData = this.#module.decode(data, ignoreColorSpace);
     if (!imageData) {
diff --git a/test/fuzz/jpx_image.fuzz.js b/test/fuzz/jpx_image.fuzz.js
index 0003711ba..72aa128b6 100644
--- a/test/fuzz/jpx_image.fuzz.js
+++ b/test/fuzz/jpx_image.fuzz.js
@@ -18,7 +18,7 @@ function ignoredError(error) {
  */
 function fuzz(data) {
   try {
-    new JpxImage().parse(new Uint8Array(data));
+    JpxImage.decode(new Uint8Array(data));
   } catch (error) {
     if (error.message && !ignoredError(error)) {
       throw error;