mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Replace instanceof Object with typeof checks

Browse source 
Using `instanceof Object` is generally problematic, since it's not guaranteed to always do the right thing for all Objects.
(I stumbled upon this while working on another patch, when I noticed that the `outlineView` was broken with workers disabled.)
This commit is contained in:
Jonas Jenwald 2021-07-03 11:15:13 +02:00
parent d80651e572
commit 909ff8e29f
4 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
web/pdf_link_service.js
View file

@ -114,7 +114,7 @@ class PDFLinkService {
const destRef = explicitDest[0];
let pageNumber;
if (destRef instanceof Object) {
if (typeof destRef === "object" && destRef !== null) {
pageNumber = this._cachedPageNumber(destRef);
if (pageNumber === null) {

2
web/pdf_outline_viewer.js
View file

@ -304,7 +304,7 @@ class PDFOutlineViewer extends BaseTreeViewer {
if (Array.isArray(explicitDest)) {
const [destRef] = explicitDest;
if (destRef instanceof Object) {
if (typeof destRef === "object" && destRef !== null) {
pageNumber = this.linkService._cachedPageNumber(destRef);
if (!pageNumber) {