mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 15:18:08 +02:00
Code Activity

[Editor] Avoid to use parent of editors in destroyed pages

Browse source
This commit is contained in:
Calixte Denizet 2023-09-07 12:30:29 +02:00
parent cf5a1d60a6
commit 8ab4e2e6e7
5 changed files with 106 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

85
test/integration/freetext_editor_spec.js
View file

@ -2344,4 +2344,89 @@ describe("FreeText Editor", () => {
);
});
});
describe("FreeText on several pages", () => {
let pages;
beforeAll(async () => {
pages = await loadAndWait("tracemonkey.pdf", ".annotationEditorLayer");
});
afterAll(async () => {
await closePages(pages);
});
it("must check that first annotation is selected without errors", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
await page.click("#editorFreeText");
const page1Selector = `.page[data-page-number = "1"] > .annotationEditorLayer`;
let rect = await page.$eval(page1Selector, el => {
const { x, y } = el.getBoundingClientRect();
return { x, y };
});
await page.mouse.click(rect.x + 10, rect.y + 10);
await page.waitForTimeout(10);
await page.type(`${getEditorSelector(0)} .internal`, "Hello");
// Commit.
await page.keyboard.press("Escape");
await page.waitForTimeout(10);
// Go to the last page.
await page.keyboard.press("End");
await page.waitForTimeout(10);
const page14Selector = `.page[data-page-number = "14"] > .annotationEditorLayer`;
await page.waitForSelector(page14Selector, {
visible: true,
timeout: 0,
});
await page.waitForTimeout(10);
rect = await page.$eval(page14Selector, el => {
const { x, y } = el.getBoundingClientRect();
return { x, y };
});
await page.mouse.click(rect.x + 10, rect.y + 10);
await page.waitForTimeout(10);
await page.type(`${getEditorSelector(0)} .internal`, "World");
await page.keyboard.press("Escape");
await page.waitForTimeout(10);
for (let i = 0; i <= 13; i++) {
await page.keyboard.press("P");
await page.waitForTimeout(10);
}
await page.waitForSelector(getEditorSelector(0), {
visible: true,
timeout: 0,
});
await page.waitForTimeout(10);
rect = await page.$eval(getEditorSelector(0), el => {
const { x, y, width, height } = el.getBoundingClientRect();
return {
x,
y,
width,
height,
};
});
await page.mouse.click(
rect.x + rect.width / 2,
rect.y + rect.height / 2
);
const content = await page.$eval(getEditorSelector(0), el =>
el.innerText.trimEnd()
);
expect(content).withContext(`In ${browserName}`).toEqual("Hello");
})
);
});
});
});

2
test/integration/test_utils.js
View file

@ -53,6 +53,8 @@ exports.loadAndWait = (filename, selector, zoom, pageSetup) =>
exports.closePages = pages =>
Promise.all(
pages.map(async ([_, page]) => {
// Avoid to keep something from a previous test.
await page.evaluate(() => window.localStorage.clear());
await page.close();
})
);