mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 14:48:08 +02:00
Code Activity

Merge pull request #18605 from Snuffleupagus/issue-18196

Browse source 
Handle the "switchannotationeditorparams" event in the editor-code (issue 18196)
This commit is contained in:
Tim van der Meij 2024-08-13 19:42:20 +02:00 • committed by GitHub
commit 8446d3ac03
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/display/editor/tools.js
View file

@ -776,21 +776,18 @@ class AnnotationEditorUIManager {
this.#viewer = viewer;
this.#altTextManager = altTextManager;
this._eventBus = eventBus;
this._eventBus._on("editingaction", this.onEditingAction.bind(this), {
signal,
});
this._eventBus._on("pagechanging", this.onPageChanging.bind(this), {
signal,
});
this._eventBus._on("scalechanging", this.onScaleChanging.bind(this), {
signal,
});
this._eventBus._on("rotationchanging", this.onRotationChanging.bind(this), {
signal,
});
this._eventBus._on("setpreference", this.onSetPreference.bind(this), {
eventBus._on("editingaction", this.onEditingAction.bind(this), { signal });
eventBus._on("pagechanging", this.onPageChanging.bind(this), { signal });
eventBus._on("scalechanging", this.onScaleChanging.bind(this), { signal });
eventBus._on("rotationchanging", this.onRotationChanging.bind(this), {
signal,
});
eventBus._on("setpreference", this.onSetPreference.bind(this), { signal });
eventBus._on(
"switchannotationeditorparams",
evt => this.updateParams(evt.type, evt.value),
{ signal }
);
this.#addSelectionListener();
this.#addDragAndDropListeners();
this.#addKeyboardManager();

5
web/app.js
View file

@ -1939,11 +1939,6 @@ const PDFViewerApplication = {
evt => (pdfViewer.annotationEditorMode = evt),
{ signal }
);
eventBus._on(
"switchannotationeditorparams",
evt => (pdfViewer.annotationEditorParams = evt),
{ signal }
);
eventBus._on("print", this.triggerPrinting.bind(this), { signal });
eventBus._on("download", this.downloadOrSave.bind(this), { signal });
eventBus._on("firstpage", () => (this.page = 1), { signal });

8
web/pdf_viewer.js
View file

@ -2363,14 +2363,6 @@ class PDFViewer {
updater();
}
// eslint-disable-next-line accessor-pairs
set annotationEditorParams({ type, value }) {
if (!this.#annotationEditorUIManager) {
throw new Error(`The AnnotationEditor is not enabled.`);
}
this.#annotationEditorUIManager.updateParams(type, value);
}
refresh(noUpdate = false, updateArgs = Object.create(null)) {
if (!this.pdfDocument) {
return;