mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-25 17:48:07 +02:00
Code Activity

Remove most assert() calls (issue 8506)

Browse source 
This replaces `assert` calls with `throw new FormatError()`/`throw new Error()`.
In a few places, throwing an `Error` (which is what `assert` meant) isn't correct since the enclosing function is supposed to return a `Promise`, hence some cases were changed to `Promise.reject(...)` and similarily for `createPromiseCapability` instances.
This commit is contained in:
Jonas Jenwald 2017-07-20 14:04:54 +02:00
parent 09f04eccda
commit 814fa1dee3
12 changed files with 193 additions and 89 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/core/pattern.js
View file

@ -328,7 +328,9 @@ Shadings.Mesh = (function MeshClosure() {
var coord = reader.readCoordinate();
var color = reader.readComponents();
if (verticesLeft === 0) { // ignoring flags if we started a triangle
assert((0 <= f && f <= 2), 'Unknown type4 flag');
if (!(0 <= f && f <= 2)) {
throw new FormatError('Unknown type4 flag');
}
switch (f) {
case 0:
verticesLeft = 3;
@ -492,7 +494,9 @@ Shadings.Mesh = (function MeshClosure() {
var cs = new Int32Array(4); // c00, c30, c03, c33
while (reader.hasData) {
var f = reader.readFlag();
assert((0 <= f && f <= 3), 'Unknown type6 flag');
if (!(0 <= f && f <= 3)) {
throw new FormatError('Unknown type6 flag');
}
var i, ii;
var pi = coords.length;
for (i = 0, ii = (f !== 0 ? 8 : 12); i < ii; i++) {
@ -602,7 +606,9 @@ Shadings.Mesh = (function MeshClosure() {
var cs = new Int32Array(4); // c00, c30, c03, c33
while (reader.hasData) {
var f = reader.readFlag();
assert((0 <= f && f <= 3), 'Unknown type7 flag');
if (!(0 <= f && f <= 3)) {
throw new FormatError('Unknown type7 flag');
}
var i, ii;
var pi = coords.length;
for (i = 0, ii = (f !== 0 ? 12 : 16); i < ii; i++) {
@ -706,7 +712,9 @@ Shadings.Mesh = (function MeshClosure() {
}
function Mesh(stream, matrix, xref, res) {
assert(isStream(stream), 'Mesh data is not a stream');
if (!isStream(stream)) {
throw new FormatError('Mesh data is not a stream');
}
var dict = stream.dict;
this.matrix = matrix;
this.shadingType = dict.get('ShadingType');
@ -743,7 +751,9 @@ Shadings.Mesh = (function MeshClosure() {
break;
case ShadingType.LATTICE_FORM_MESH:
var verticesPerRow = dict.get('VerticesPerRow') | 0;
assert(verticesPerRow >= 2, 'Invalid VerticesPerRow');
if (verticesPerRow < 2) {
throw new FormatError('Invalid VerticesPerRow');
}
decodeType5Shading(this, reader, verticesPerRow);
break;
case ShadingType.COONS_PATCH_MESH: