mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Simplify the "fileattachmentannotation"-event handling a little bit

Browse source 
*This patch can be tested, in the viewer, using the `annotation-fileattachment.pdf` document from the test-suite.*

Note how the `FileSpec`-implementation already uses `stringToPDFString` during the filename lookup, see cfac6fa511/src/core/file_spec.js (L70)
Hence there's no reason to repeat that again in the `FileAttachmentAnnotationElement`-constructor, and we can thus simplify the "fileattachmentannotation"-event handling a little bit.
This commit is contained in:
Jonas Jenwald 2022-05-06 20:45:53 +02:00
parent cfac6fa511
commit 7f40ef41a5
2 changed files with 7 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/display/annotation_layer.js
View file

@ -23,7 +23,6 @@ import {
AnnotationType,
assert,
shadow,
stringToPDFString,
unreachable,
Util,
warn,
@ -2296,7 +2295,6 @@ class FileAttachmentAnnotationElement extends AnnotationElement {
this.linkService.eventBus?.dispatch("fileattachmentannotation", {
source: this,
id: stringToPDFString(filename),
filename,
content,
});