mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Ensure that the pdf.sandbox.js scriptElement is also removed from the DOM (PR 12695 follow-up)

Browse source 
I completely missed this previously, but we obviously should remove the scriptElement as well to *really* clean-up everything properly.

Given that there's multiple existing usages of `loadScript` in the code-base, the safest/quickest solution seemed to be to have call-sites opt-in to remove the scriptElement using a new parameter.
This commit is contained in:
Jonas Jenwald 2020-12-07 17:11:32 +01:00
parent b194c820bf
commit 7ce6634c51
2 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
web/genericcom.js
View file

@ -41,7 +41,10 @@ class GenericPreferences extends BasePreferences {
class GenericScripting {
constructor() {
this._ready = loadScript(AppOptions.get("sandboxBundleSrc")).then(() => {
this._ready = loadScript(
AppOptions.get("sandboxBundleSrc"),
/* removeScriptElement = */ true
).then(() => {
return window.pdfjsSandbox.QuickJSSandbox();
});
}