mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-20 15:18:08 +02:00
Polyfill structuredClone
with core-js (PR 13948 follow-up)
This allows us to remove the manually implemented `structuredClone` polyfill, thus reducing the maintenance burden for the `LoopbackPort` class; refer to https://github.com/zloirock/core-js#structuredclone *Please note:* While `structuredClone` support landed already in Firefox 94, Google Chrome only added it in version 98 (currently in Beta). However, given that the `LoopbackPort` will only be used together with *fake workers* in browsers this shouldn't be too much of a problem.[1] For Node.js environments, where *fake workers* are unfortunately necessary, using a `legacy/`-build is already required which thus guarantees that the `structuredClone` polyfill is available. Also, the patch updates core-js to the latest version since that one includes `structuredClone` improvements; please see https://github.com/zloirock/core-js/releases/tag/v3.20.3 --- [1] Given that we only support browsers with proper worker support, if *fake workers* are being used that essentially indicates a configuration problem/error.
This commit is contained in:
parent
2fcd07f400
commit
7cc761a8c0
5 changed files with 47 additions and 98 deletions
|
@ -1913,91 +1913,14 @@ class LoopbackPort {
|
|||
}
|
||||
|
||||
postMessage(obj, transfers) {
|
||||
function cloneValue(object) {
|
||||
if (
|
||||
(typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) ||
|
||||
globalThis.structuredClone
|
||||
) {
|
||||
return globalThis.structuredClone(object, transfers);
|
||||
}
|
||||
|
||||
// Trying to perform a structured clone close to the spec, including
|
||||
// transfers.
|
||||
function fallbackCloneValue(value) {
|
||||
if (
|
||||
typeof value === "function" ||
|
||||
typeof value === "symbol" ||
|
||||
value instanceof URL
|
||||
) {
|
||||
throw new Error(
|
||||
`LoopbackPort.postMessage - cannot clone: ${value?.toString()}`
|
||||
);
|
||||
}
|
||||
|
||||
if (typeof value !== "object" || value === null) {
|
||||
return value;
|
||||
}
|
||||
if (cloned.has(value)) {
|
||||
// already cloned the object
|
||||
return cloned.get(value);
|
||||
}
|
||||
let buffer, result;
|
||||
if ((buffer = value.buffer) && isArrayBuffer(buffer)) {
|
||||
// We found object with ArrayBuffer (typed array).
|
||||
if (transfers?.includes(buffer)) {
|
||||
result = new value.constructor(
|
||||
buffer,
|
||||
value.byteOffset,
|
||||
value.byteLength
|
||||
);
|
||||
} else {
|
||||
result = new value.constructor(value);
|
||||
}
|
||||
cloned.set(value, result);
|
||||
return result;
|
||||
}
|
||||
if (value instanceof Map) {
|
||||
result = new Map();
|
||||
cloned.set(value, result); // Adding to cache now for cyclic references.
|
||||
for (const [key, val] of value) {
|
||||
result.set(key, fallbackCloneValue(val));
|
||||
}
|
||||
return result;
|
||||
}
|
||||
if (value instanceof Set) {
|
||||
result = new Set();
|
||||
cloned.set(value, result); // Adding to cache now for cyclic references.
|
||||
for (const val of value) {
|
||||
result.add(fallbackCloneValue(val));
|
||||
}
|
||||
return result;
|
||||
}
|
||||
result = Array.isArray(value) ? [] : Object.create(null);
|
||||
cloned.set(value, result); // Adding to cache now for cyclic references.
|
||||
// Cloning all value and object properties, however ignoring properties
|
||||
// defined via getter.
|
||||
for (const i in value) {
|
||||
let desc,
|
||||
p = value;
|
||||
while (!(desc = Object.getOwnPropertyDescriptor(p, i))) {
|
||||
p = Object.getPrototypeOf(p);
|
||||
}
|
||||
if (typeof desc.value === "undefined") {
|
||||
continue;
|
||||
}
|
||||
if (typeof desc.value === "function" && !value.hasOwnProperty?.(i)) {
|
||||
continue;
|
||||
}
|
||||
result[i] = fallbackCloneValue(desc.value);
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
||||
const cloned = new WeakMap();
|
||||
return fallbackCloneValue(object);
|
||||
}
|
||||
|
||||
const event = { data: cloneValue(obj) };
|
||||
const event = {
|
||||
data:
|
||||
typeof PDFJSDev === "undefined" ||
|
||||
PDFJSDev.test("SKIP_BABEL") ||
|
||||
transfers
|
||||
? structuredClone(obj, transfers)
|
||||
: structuredClone(obj),
|
||||
};
|
||||
|
||||
this._deferred.then(() => {
|
||||
for (const listener of this._listeners) {
|
||||
|
|
|
@ -100,4 +100,17 @@ if (
|
|||
globalThis.ReadableStream =
|
||||
require("web-streams-polyfill/dist/ponyfill.js").ReadableStream;
|
||||
})();
|
||||
|
||||
// Support: Firefox<94, Chrome<98, Safari, Node.js<17.0.0
|
||||
(function checkStructuredClone() {
|
||||
if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("IMAGE_DECODERS")) {
|
||||
// The current image decoders are synchronous, hence `structuredClone`
|
||||
// shouldn't need to be polyfilled for the IMAGE_DECODERS build target.
|
||||
return;
|
||||
}
|
||||
if (globalThis.structuredClone) {
|
||||
return;
|
||||
}
|
||||
require("core-js/web/structured-clone.js");
|
||||
})();
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue