diff --git a/test/integration/stamp_editor_spec.mjs b/test/integration/stamp_editor_spec.mjs index 9ab373453..fa2352e07 100644 --- a/test/integration/stamp_editor_spec.mjs +++ b/test/integration/stamp_editor_spec.mjs @@ -16,7 +16,6 @@ import { applyFunctionToEditor, awaitPromise, - cleanupEditing, clearEditors, clearInput, closePages, @@ -31,7 +30,6 @@ import { getRect, getSerialized, isCanvasMonochrome, - isVisible, kbBigMoveDown, kbBigMoveRight, kbUndo, @@ -101,7 +99,7 @@ describe("Stamp Editor", () => { describe("Basic operations", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("empty.pdf", ".annotationEditorLayer", null, { eventBusSetup: eventBus => { eventBus.on("annotationeditoruimanager", ({ uiManager }) => { @@ -112,10 +110,6 @@ describe("Stamp Editor", () => { }); afterEach(async () => { - await cleanupEditing(pages, switchToStamp); - }); - - afterAll(async () => { await closePages(pages); }); @@ -203,7 +197,7 @@ describe("Stamp Editor", () => { describe("Resize", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("empty.pdf", ".annotationEditorLayer", 50, { eventBusSetup: eventBus => { eventBus.on("annotationeditoruimanager", ({ uiManager }) => { @@ -213,12 +207,8 @@ describe("Stamp Editor", () => { }); }); - afterAll(async () => { - await closePages(pages); - }); - afterEach(async () => { - await cleanupEditing(pages, switchToStamp); + await closePages(pages); }); it("must check that an added image stay within the page", async () => { @@ -325,11 +315,11 @@ describe("Stamp Editor", () => { describe("Alt text dialog", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("empty.pdf", ".annotationEditorLayer", 50); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -500,11 +490,11 @@ describe("Stamp Editor", () => { describe("Resize an image with the keyboard", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("empty.pdf", ".annotationEditorLayer", 50); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -631,12 +621,12 @@ describe("Stamp Editor", () => { describe("Copy/paste from a tab to an other", () => { let pages1, pages2; - beforeAll(async () => { + beforeEach(async () => { pages1 = await loadAndWait("empty.pdf", ".annotationEditorLayer"); pages2 = await loadAndWait("empty.pdf", ".annotationEditorLayer"); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages1); await closePages(pages2); }); @@ -665,11 +655,11 @@ describe("Stamp Editor", () => { describe("Undo a stamp", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("tracemonkey.pdf", ".annotationEditorLayer"); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -697,11 +687,11 @@ describe("Stamp Editor", () => { describe("Delete a stamp and undo it on another page", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("tracemonkey.pdf", ".annotationEditorLayer"); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -742,11 +732,11 @@ describe("Stamp Editor", () => { describe("Delete a stamp, scroll and undo it", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("tracemonkey.pdf", ".annotationEditorLayer"); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -782,11 +772,11 @@ describe("Stamp Editor", () => { describe("Resize a stamp", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("empty.pdf", ".annotationEditorLayer"); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -832,7 +822,7 @@ describe("Stamp Editor", () => { describe("Add a stamp in odd spread mode", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait( "empty.pdf", ".annotationEditorLayer", @@ -844,7 +834,7 @@ describe("Stamp Editor", () => { ); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -873,11 +863,11 @@ describe("Stamp Editor", () => { describe("Copy and paste a stamp with an alt text", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("empty.pdf", ".annotationEditorLayer"); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -918,7 +908,7 @@ describe("Stamp Editor", () => { describe("New alt-text flow", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait( "empty.pdf", ".annotationEditorLayer", @@ -942,23 +932,6 @@ describe("Stamp Editor", () => { }); afterEach(async () => { - for (const [, page] of pages) { - if (await isVisible(page, "#newAltTextDialog")) { - await page.keyboard.press("Escape"); - await page.waitForSelector("#newAltTextDisclaimer", { - visible: false, - }); - } - await page.evaluate(() => { - window.uiManager.reset(); - window.telemetry = []; - }); - // Disable editing mode. - await switchToStamp(page, /* disable */ true); - } - }); - - afterAll(async () => { await closePages(pages); }); @@ -1296,7 +1269,7 @@ describe("Stamp Editor", () => { describe("New alt-text flow (bug 1920515)", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait( "empty.pdf", ".annotationEditorLayer", @@ -1318,22 +1291,6 @@ describe("Stamp Editor", () => { }); afterEach(async () => { - for (const [, page] of pages) { - if (await isVisible(page, "#newAltTextDialog")) { - await page.keyboard.press("Escape"); - await page.waitForSelector("#newAltTextDisclaimer", { - visible: false, - }); - } - await page.evaluate(() => { - window.uiManager.reset(); - }); - // Disable editing mode. - await switchToStamp(page, /* disable */ true); - } - }); - - afterAll(async () => { await closePages(pages); }); @@ -1364,11 +1321,11 @@ describe("Stamp Editor", () => { describe("No auto-resize", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("empty.pdf", ".annotationEditorLayer", 67); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -1410,11 +1367,11 @@ describe("Stamp Editor", () => { describe("A stamp musn't be on top of the secondary toolbar", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("empty.pdf", ".annotationEditorLayer", 600); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -1453,11 +1410,11 @@ describe("Stamp Editor", () => { describe("Stamp (move existing)", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("stamps.pdf", getAnnotationSelector("25R")); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -1491,11 +1448,11 @@ describe("Stamp Editor", () => { describe("Stamp (change alt-text)", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("stamps.pdf", getAnnotationSelector("58R")); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -1551,11 +1508,11 @@ describe("Stamp Editor", () => { describe("Stamp (delete existing and undo)", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("stamps.pdf", getAnnotationSelector("37R")); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -1599,11 +1556,11 @@ describe("Stamp Editor", () => { describe("Drag a stamp annotation and click on a touchscreen", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("empty.pdf", ".annotationEditorLayer"); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -1725,11 +1682,11 @@ describe("Stamp Editor", () => { describe("Switch to edit mode a pdf with an existing stamp annotation on an invisible and rendered page", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("issue19239.pdf", ".annotationEditorLayer"); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -1755,11 +1712,11 @@ describe("Stamp Editor", () => { describe("Switch to edit mode a pdf with an existing stamp annotation on an invisible and unrendered page", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("issue19239.pdf", ".annotationEditorLayer"); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -1794,11 +1751,11 @@ describe("Stamp Editor", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("issue19239.pdf", annotationSelector); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); @@ -1825,11 +1782,11 @@ describe("Stamp Editor", () => { let pages; - beforeAll(async () => { + beforeEach(async () => { pages = await loadAndWait("red_stamp.pdf", annotationSelector, 20); }); - afterAll(async () => { + afterEach(async () => { await closePages(pages); }); diff --git a/test/integration/test_utils.mjs b/test/integration/test_utils.mjs index db1f31995..90e137ada 100644 --- a/test/integration/test_utils.mjs +++ b/test/integration/test_utils.mjs @@ -137,13 +137,6 @@ function closePages(pages) { return Promise.all(pages.map(([_, page]) => closeSinglePage(page))); } -function isVisible(page, selector) { - return page.evaluate( - sel => document.querySelector(sel)?.checkVisibility(), - selector - ); -} - async function closeSinglePage(page) { // Avoid to keep something from a previous test. await page.evaluate(async () => { @@ -861,16 +854,6 @@ function isCanvasMonochrome(page, pageNumber, rectangle, color) { ); } -async function cleanupEditing(pages, switcher) { - for (const [, page] of pages) { - await page.evaluate(() => { - window.uiManager.reset(); - }); - // Disable editing mode. - await switcher(page, /* disable */ true); - } -} - async function getXY(page, selector) { const rect = await getRect(page, selector); return `${rect.x}::${rect.y}`; @@ -902,7 +885,6 @@ async function moveEditor(page, selector, n, pressKey) { export { applyFunctionToEditor, awaitPromise, - cleanupEditing, clearEditors, clearInput, closePages, @@ -927,7 +909,6 @@ export { getXY, hover, isCanvasMonochrome, - isVisible, kbBigMoveDown, kbBigMoveLeft, kbBigMoveRight,