mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 06:38:07 +02:00
Code Activity

Improve addSignatureDescription/editSignatureDescription handling (issue 19683)

Browse source 
- Point the `addSignatureDescription` respectively `editSignatureDescription` labels to their actual `input`-elements (this way clicking the label will actually focus the input).

 - Add the event listener to the `addSignatureDescription`-input, rather than its `span`-element (this is consistent with the `editSignatureDescription` case).

 - Correctly check if the `addSignatureDescription`-input is empty, since we're accidentally comparing with its `span`-element.

 - Remove unbalanced, and likely accidentally added, `</span>` tags.
This commit is contained in:
Jonas Jenwald 2025-03-19 11:19:47 +01:00
parent 00e3a4d87a
commit 79058c92e3
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
web/signature_manager.js
View file

@ -187,10 +187,10 @@ class SignatureManager {
}, },
{ passive: true } { passive: true }
); );
description.addEventListener( this.#description.addEventListener(
"input", "input",
() => { () => {
this.#clearDescription.disabled = description.value === ""; this.#clearDescription.disabled = this.#description.value === "";
}, },
{ passive: true } { passive: true }
); );

8
web/viewer.html
View file

@ -716,9 +716,9 @@ See https://github.com/adobe-type-tools/cmap-resources
<div id="addSignatureControls"> <div id="addSignatureControls">
<div id="horizontalContainer"> <div id="horizontalContainer">
<div id="addSignatureDescriptionContainer"> <div id="addSignatureDescriptionContainer">
<label for="addSignatureDescription" data-l10n-id="pdfjs-editor-add-signature-description-label"></span></label> <label for="addSignatureDescInput" data-l10n-id="pdfjs-editor-add-signature-description-label"></label>
<span id="addSignatureDescription" class="inputWithClearButton"> <span id="addSignatureDescription" class="inputWithClearButton">
<input type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input> <input id="addSignatureDescInput" type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
<button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button> <button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button>
</span> </span>
</div> </div>
@ -755,9 +755,9 @@ See https://github.com/adobe-type-tools/cmap-resources
</div> </div>
<div id="editSignatureDescriptionAndView"> <div id="editSignatureDescriptionAndView">
<div id="editSignatureDescriptionContainer"> <div id="editSignatureDescriptionContainer">
<label for="editSignatureDescription" data-l10n-id="pdfjs-editor-add-signature-description-label"></span></label> <label for="editSignatureDescInput" data-l10n-id="pdfjs-editor-add-signature-description-label"></label>
<span id="editSignatureDescription" class="inputWithClearButton"> <span id="editSignatureDescription" class="inputWithClearButton">
<input type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input> <input id="editSignatureDescInput" type="text" data-l10n-id="pdfjs-editor-add-signature-description-input" tabindex="0"></input>
<button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button> <button class="clearInputButton" type="button" tabindex="0" aria-hidden="true"></button>
</span> </span>
</div> </div>