mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 15:18:08 +02:00
Code Activity

Convert the remaining functions in src/core/primitives.js to use standard classes

Browse source 
This patch was tested using the PDF file from issue 2618, i.e. https://bug570667.bugzilla-attachments.gnome.org/attachment.cgi?id=226471, with the following manifest file:
```
[
    {  "id": "issue2618",
       "file": "../web/pdfs/issue2618.pdf",
       "md5": "",
       "rounds": 50,
       "type": "eq"
    }
]
```

which gave the following results when comparing this patch against the `master` branch:
```
-- Grouped By browser, stat --
browser | stat         | Count | Baseline(ms) | Current(ms) | +/- |   %  | Result(P<.05)
------- | ------------ | ----- | ------------ | ----------- | --- | ---- | -------------
firefox | Overall      |    50 |         3417 |        3426 |   9 | 0.27 |
firefox | Page Request |    50 |            1 |           1 |   0 | 5.41 |
firefox | Rendering    |    50 |         3416 |        3426 |   9 | 0.27 |
```

Based on these results, there's no significant performance regression from using standard classes and this patch should thus be OK.
This commit is contained in:
Jonas Jenwald 2021-05-11 17:08:26 +02:00
parent dda1a9a7b1
commit 757636d519
2 changed files with 136 additions and 142 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/unit/annotation_spec.js
View file

@ -1192,8 +1192,8 @@ describe("annotation", function () {
expect(data.url).toBeUndefined();
expect(data.unsafeUrl).toBeUndefined();
expect(data.dest).toEqual([
{ num: 17, gen: 0 },
{ name: "XYZ" },
Ref.get(17, 0),
Name.get("XYZ"),
0,
841.89,
null,