mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Only include the renderer-preference in builds where SVGGraphics is defined

Browse source 
After PR 13117 it's now (finally) possible for *different* build targets to specify individual options/preferences, and we can utilize that to only expose the `renderer`-preference in builds where `SVGGraphics` is actually defined.
Note that for e.g. `MOZCENTRAL`-builds, trying to enable SVG-rendering will throw immediately and the preference thus doesn't make sense to include there.

Also, update the dummy `SVGGraphics` to use a class, tweak the `PDFJSDev`-check in `src/display/svg.js` to agree fully with the option/preference, and remove an unnecessary `eslint-disable`.
This commit is contained in:
Jonas Jenwald 2021-05-10 11:33:06 +02:00
parent f07d50f8ee
commit 7548dc5ea2
3 changed files with 13 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/display/svg.js
View file

@ -22,6 +22,7 @@ import {
isNum,
OPS,
TextRenderingMode,
unreachable,
Util,
warn,
} from "../shared/util.js";
@ -29,11 +30,16 @@ import { DOMSVGFactory } from "./display_utils.js";
import { isNodeJS } from "../shared/is_node.js";
/** @type {any} */
let SVGGraphics = function () {
throw new Error("Not implemented: SVGGraphics");
let SVGGraphics = class {
constructor() {
unreachable("Not implemented: SVGGraphics");
}
};
if (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) {
if (
typeof PDFJSDev === "undefined" ||
PDFJSDev.test("!PRODUCTION || GENERIC")
) {
const SVG_DEFAULTS = {
fontStyle: "normal",
fontWeight: "normal",
@ -438,8 +444,7 @@ if (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) {
let maskCount = 0;
let shadingCount = 0;
// eslint-disable-next-line no-shadow
SVGGraphics = class SVGGraphics {
SVGGraphics = class {
constructor(commonObjs, objs, forceDataSchema = false) {
this.svgFactory = new DOMSVGFactory();