mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Remove the FIREFOX build flag, since it's completely unused

Browse source 
After PR 9566, which removed all of the old Firefox extension code, the `FIREFOX` build flag is no longer used for anything.
It thus seems to me that it should be removed, for a couple of reasons:
 - It's simply dead code now, which only serves to add confusion when looking at the `PDFJSDev` calls.
 - It used to be that `MOZCENTRAL` and `FIREFOX` was *almost* always used together. However, ever since PR 9566 there's obviously been no effort put into keeping the `FIREFOX` build flags up to date.
 - In the event that a new, Webextension based, Firefox addon is created in the future you'd still need to audit all `MOZCENTRAL` (and possibly `CHROME`) build flags to see what'd make sense for the addon.
This commit is contained in:
Jonas Jenwald 2020-01-08 13:57:31 +01:00
parent ead03b513c
commit 7322a24ce4
13 changed files with 30 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/display/network.js
View file

@ -25,10 +25,9 @@ import {
validateRangeRequestCapabilities,
} from "./network_utils.js";
if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("FIREFOX || MOZCENTRAL")) {
if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
throw new Error(
'Module "./network" shall not ' +
"be used with FIREFOX or MOZCENTRAL build."
'Module "./network.js" shall not be used with MOZCENTRAL builds.'
);
}

2
src/display/text_layer.js
View file

@ -601,7 +601,7 @@ var renderTextLayer = (function renderTextLayerClosure() {
let canvas = document.createElement("canvas");
if (
typeof PDFJSDev === "undefined" ||
PDFJSDev.test("FIREFOX || MOZCENTRAL || GENERIC")
PDFJSDev.test("MOZCENTRAL || GENERIC")
) {
canvas.mozOpaque = true;
}