mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-29 15:47:57 +02:00
Code Activity

Fix (most) LGTM warnings

Browse source 
Most of the warnings we don't really care about, and those are simply white-listed using inline comments; however two cases prompted actual code changes:

 - In `src/display/pattern_helper.js` the branch in question is indeed unreachable, and should thus be safe to remove. (This code originated in PR 4192, which is now over seven years ago.)

 - In `test/test.js`, the function in question indeed doesn't accept any arguments. (The patch also re-formats a string just above, which didn't seem worthy of a separated patch.)

This now leaves only *one* warning in the LGTM report, however that one is a false positive that we'll need to report upstream.
This commit is contained in:
Jonas Jenwald 2021-07-24 13:54:52 +02:00
parent 834a638aad
commit 70bac87fed
5 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/integration/scripting_spec.js
View file

@ -22,7 +22,7 @@ describe("Interaction", () => {
}
await action();
await page.waitForFunction(
`document.querySelector("${selector.replace("\\", "\\\\")}").value !== ""`
`document.querySelector("${selector.replace("\\", "\\\\")}").value !== ""` // lgtm [js/incomplete-sanitization]
);
return page.$eval(selector, el => el.value);
}