mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Fix (most) LGTM warnings

Browse source 
Most of the warnings we don't really care about, and those are simply white-listed using inline comments; however two cases prompted actual code changes:

 - In `src/display/pattern_helper.js` the branch in question is indeed unreachable, and should thus be safe to remove. (This code originated in PR 4192, which is now over seven years ago.)

 - In `test/test.js`, the function in question indeed doesn't accept any arguments. (The patch also re-formats a string just above, which didn't seem worthy of a separated patch.)

This now leaves only *one* warning in the LGTM report, however that one is a false positive that we'll need to report upstream.
This commit is contained in:
Jonas Jenwald 2021-07-24 13:54:52 +02:00
parent 834a638aad
commit 70bac87fed
5 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/file_spec.js
View file

@ -67,7 +67,7 @@ class FileSpec {
if (!this._filename && this.root) {
const filename = pickPlatformItem(this.root) || "unnamed";
this._filename = stringToPDFString(filename)
.replace(/\\\\/g, "\\")
.replace(/\\\\/g, "\\") // lgtm [js/double-escaping]
.replace(/\\\//g, "/")
.replace(/\\/g, "/");
}

2
src/display/pattern_helper.js
View file

@ -192,8 +192,6 @@ function drawTriangle(data, context, p1, p2, p3, c1, c2, c3) {
let k;
if (y < y1) {
k = 0;
} else if (y1 === y2) {
k = 1;
} else {
k = (y1 - y) / (y1 - y2);
}