mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

Change DownloadManager.download to use Uint8Array-data

Browse source 
Part of this code is really old and pre-dates general availability of things such as `Blob` and `URL.createObjectURL`. To avoid having to duplicate the Blob-creation in the viewer, we can move this into `DownloadManager.download` instead.

Also, remove a couple of unnecessary `await` statements since the methods in question are synchronous.
This commit is contained in:
Jonas Jenwald 2024-06-07 13:15:41 +02:00
parent 6a71f692bf
commit 66e189c9aa
4 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

10
web/app.js
View file

@ -1083,13 +1083,11 @@ const PDFViewerApplication = {
this._ensureDownloadComplete();
const data = await this.pdfDocument.getData();
const blob = new Blob([data], { type: "application/pdf" });
await this.downloadManager.download(blob, url, filename, options);
this.downloadManager.download(data, url, filename, options);
} catch {
// When the PDF document isn't ready, or the PDF file is still
// downloading, simply download using the URL.
await this.downloadManager.downloadUrl(url, filename, options);
this.downloadManager.downloadUrl(url, filename, options);
}
},
@ -1106,9 +1104,7 @@ const PDFViewerApplication = {
this._ensureDownloadComplete();
const data = await this.pdfDocument.saveDocument();
const blob = new Blob([data], { type: "application/pdf" });
await this.downloadManager.download(blob, url, filename, options);
this.downloadManager.download(data, url, filename, options);
} catch (reason) {
// When the PDF document isn't ready, or the PDF file is still
// downloading, simply fallback to a "regular" download.

6
web/download_manager.js
View file

@ -113,8 +113,10 @@ class DownloadManager {
return false;
}
download(blob, url, filename, _options) {
const blobUrl = URL.createObjectURL(blob);
download(data, url, filename, _options) {
const blobUrl = URL.createObjectURL(
new Blob([data], { type: "application/pdf" })
);
download(blobUrl, filename);
}
}

6
web/firefoxcom.js
View file

@ -140,8 +140,10 @@ class DownloadManager {
return false;
}
download(blob, url, filename, options = {}) {
const blobUrl = URL.createObjectURL(blob);
download(data, url, filename, options = {}) {
const blobUrl = URL.createObjectURL(
new Blob([data], { type: "application/pdf" })
);
FirefoxCom.request("download", {
blobUrl,

4
web/interfaces.js
View file

@ -160,12 +160,12 @@ class IDownloadManager {
openOrDownloadData(data, filename, dest = null) {}
/**
* @param {Blob} blob
* @param {Uint8Array} data
* @param {string} url
* @param {string} filename
* @param {Object} [options]
*/
download(blob, url, filename, options) {}
download(data, url, filename, options) {}
}
/**