mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

Try to shutdown Fluent "more" when closing the viewer during testing

Browse source 
Even with PR 18280 fixed, we still *occasionally* see l10n-related errors when closing the integration-tests on the bots.
This commit is contained in:
Jonas Jenwald 2024-06-22 14:21:51 +02:00
parent f9ff613e56
commit 6492587066
2 changed files with 22 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
web/app.js
View file

@ -2111,16 +2111,15 @@ const PDFViewerApplication = {
* @ignore
*/
async testingClose() {
this.l10n?.pause();
this.findBar?.close();
this.unbindEvents();
this.unbindWindowEvents();
this._globalAbortController?.abort();
this._globalAbortController = null;
await this.close();
this.findBar?.close();
await Promise.all([this.l10n?.destroy(), this.close()]);
},
_accumulateTicks(ticks, prop) {

19
web/l10n.js
View file

@ -23,6 +23,8 @@
class L10n {
#dir;
#elements = new Set();
#lang;
#l10n;
@ -69,6 +71,7 @@ class L10n {
/** @inheritdoc */
async translate(element) {
this.#elements.add(element);
try {
this.#l10n.connectRoot(element);
await this.#l10n.translateRoots();
@ -77,6 +80,22 @@ class L10n {
}
}
/** @inheritdoc */
async destroy() {
for (const element of this.#elements) {
this.#l10n.disconnectRoot(element);
}
this.#elements.clear();
this.#l10n.pauseObserving();
// Since `disconnectRoot`/`pauseObserving` can still trigger asynchronous
// operations, without any way to actually cancel them, attempt to
// workaround timing issues when closing the integration-tests.
await new Promise(resolve => {
window.requestAnimationFrame(resolve);
});
}
/** @inheritdoc */
pause() {
this.#l10n.pauseObserving();