mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

Merge pull request #16555 from calixteman/empty_freetext

Browse source 
[Editor] Don't add an editor for empty FreeText annotations
This commit is contained in:
calixteman 2023-06-15 19:44:13 +02:00 • committed by GitHub
commit 64520a0c63
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/display/editor/freetext.js
View file

@ -539,6 +539,10 @@ class FreeTextEditor extends AnnotationEditor {
textContent,
page: { pageNumber },
} = data;
if (!textContent || textContent.length === 0) {
// Empty annotation.
return null;
}
initialData = data = {
annotationType: AnnotationEditorType.FREETEXT,
color: Array.from(fontColor),

23
test/integration/freetext_editor_spec.js
View file

@ -993,6 +993,29 @@ describe("FreeText Editor", () => {
});
});
describe("FreeText (update existing but not empty ones)", () => {
let pages;
beforeAll(async () => {
pages = await loadAndWait("issue14438.pdf", ".annotationEditorLayer");
});
afterAll(async () => {
await closePages(pages);
});
it("must update an existing annotation but not an empty one", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
await page.click("#editorFreeText");
const editorIds = await getEditors(page, "freeText");
expect(editorIds.length).withContext(`In ${browserName}`).toEqual(1);
})
);
});
});
describe("FreeText (delete existing)", () => {
let pages;