From 62df96894d8a89dd9ffcffeee75c93dbcf6ab6e8 Mon Sep 17 00:00:00 2001 From: Calixte Denizet Date: Wed, 26 Mar 2025 23:02:13 +0100 Subject: [PATCH] [Editor] in the signature UI, disable the description input if there is no signature (bug 1956114) --- test/integration/signature_editor_spec.mjs | 2 ++ web/signature_manager.css | 4 ++++ web/signature_manager.js | 1 + 3 files changed, 7 insertions(+) diff --git a/test/integration/signature_editor_spec.mjs b/test/integration/signature_editor_spec.mjs index 5b286b72e..472255bbf 100644 --- a/test/integration/signature_editor_spec.mjs +++ b/test/integration/signature_editor_spec.mjs @@ -93,9 +93,11 @@ describe("Signature Editor", () => { ); expect(description).withContext(browserName).toEqual(""); await page.waitForSelector(`${addButtonSelector}:disabled`); + await page.waitForSelector("#addSignatureDescInput:disabled"); await page.type("#addSignatureTypeInput", "PDF.js"); await page.waitForSelector(`${addButtonSelector}:not(:disabled)`); + await page.waitForSelector("#addSignatureDescInput:not(:disabled)"); // The save button should be enabled now. await page.waitForSelector( diff --git a/web/signature_manager.css b/web/signature_manager.css index 32174a869..b766e9dc0 100644 --- a/web/signature_manager.css +++ b/web/signature_manager.css @@ -521,6 +521,10 @@ gap: 4px; flex: 1 0 0; + &:has(input:disabled) > label { + opacity: 0.4; + } + > label { width: auto; } diff --git a/web/signature_manager.js b/web/signature_manager.js index f2f9b7347..21774949b 100644 --- a/web/signature_manager.js +++ b/web/signature_manager.js @@ -325,6 +325,7 @@ class SignatureManager { this.#saveCheckbox.disabled = this.#clearButton.disabled = this.#addButton.disabled = + this.#description.disabled = !value; }