mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 15:18:08 +02:00
Code Activity

Avoid an allocation in readCharCode().

Browse source 
readCharCode() returns two values, and currently allocates a length-2
array on every call to do so. This change makes it instead us a
passed-in object which can be reused.

This tiny change reduces the total JS allocations done for the document
in Mozilla bug 992125 by 4.2%.
This commit is contained in:
Nicholas Nethercote 2014-08-10 22:27:04 -07:00
parent 0e4d9061b2
commit 61e6b576d4
3 changed files with 21 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

20
test/unit/cmap_spec.js
View file

@ -65,12 +65,13 @@ describe('cmap', function() {
'endcodespacerange\n';
var stream = new StringStream(str);
var cmap = CMapFactory.create(stream);
var c = cmap.readCharCode(String.fromCharCode(1), 0);
expect(c[0]).toEqual(1);
expect(c[1]).toEqual(1);
c = cmap.readCharCode(String.fromCharCode(0, 0, 0, 3), 0);
expect(c[0]).toEqual(3);
expect(c[1]).toEqual(4);
var c = {};
cmap.readCharCode(String.fromCharCode(1), 0, c);
expect(c.charcode).toEqual(1);
expect(c.length).toEqual(1);
cmap.readCharCode(String.fromCharCode(0, 0, 0, 3), 0, c);
expect(c.charcode).toEqual(3);
expect(c.length).toEqual(4);
});
it('decodes 4 byte codespace ranges', function() {
var str = '1 begincodespacerange\n' +
@ -78,9 +79,10 @@ describe('cmap', function() {
'endcodespacerange\n';
var stream = new StringStream(str);
var cmap = CMapFactory.create(stream);
var c = cmap.readCharCode(String.fromCharCode(0x8E, 0xA1, 0xA1, 0xA1), 0);
expect(c[0]).toEqual(0x8EA1A1A1);
expect(c[1]).toEqual(4);
var c = {};
cmap.readCharCode(String.fromCharCode(0x8E, 0xA1, 0xA1, 0xA1), 0, c);
expect(c.charcode).toEqual(0x8EA1A1A1);
expect(c.length).toEqual(4);
});
it('read usecmap', function() {
var str = '/Adobe-Japan1-1 usecmap\n';