mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-21 15:48:06 +02:00
Code Activity

Replace the remaining occurences of instanceof Array with Array.isArray()

Browse source 
*Follow-up to PRs 8864 and 8813.*

As explained in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray, `instanceof Array` can have inconsistent behavior. To ensure that only `Array.isArray` is used, an ESLint plugin/rule is added to enforce this.
This commit is contained in:
Jonas Jenwald 2018-07-09 13:11:35 +02:00
parent 200e3d6bd8
commit 61186698c3
8 changed files with 93 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/unit/api_spec.js
View file

@ -752,12 +752,12 @@ describe('api', function() {
var promise = doc.getOutline();
promise.then(function(outline) {
// Two top level entries.
expect(outline instanceof Array).toEqual(true);
expect(Array.isArray(outline)).toEqual(true);
expect(outline.length).toEqual(2);
// Make sure some basic attributes are set.
var outlineItem = outline[1];
expect(outlineItem.title).toEqual('Chapter 1');
expect(outlineItem.dest instanceof Array).toEqual(true);
expect(Array.isArray(outlineItem.dest)).toEqual(true);
expect(outlineItem.url).toEqual(null);
expect(outlineItem.unsafeUrl).toBeUndefined();
expect(outlineItem.newWindow).toBeUndefined();
@ -778,7 +778,7 @@ describe('api', function() {
loadingTask.promise.then(function (pdfDocument) {
pdfDocument.getOutline().then(function (outline) {
expect(outline instanceof Array).toEqual(true);
expect(Array.isArray(outline)).toEqual(true);
expect(outline.length).toEqual(5);
var outlineItemTwo = outline[2];