mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Check the relevant parameters inside of the mustBeViewedWhenEditing method

Browse source 
Similar to the `mustBeViewed` method, we can check the relevant parameters within the `mustBeViewedWhenEditing` method itself since that (in my opinion) slightly helps readability of the code in the `src/core/document.js` file.
This commit is contained in:
Jonas Jenwald 2024-07-05 11:34:46 +02:00
parent 9065ee465b
commit 5f744904ac
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/core/annotation.js
View file

@ -777,8 +777,8 @@ class Annotation {
return this.printable;
}
mustBeViewedWhenEditing() {
return !this.data.isEditable;
mustBeViewedWhenEditing(isEditing, modifiedIds = null) {
return isEditing ? !this.data.isEditable : !modifiedIds?.has(this.data.id);
}
/**

3
src/core/document.js
View file

@ -582,8 +582,7 @@ class Page {
intentAny ||
(intentDisplay &&
annotation.mustBeViewed(annotationStorage, renderForms) &&
((isEditing && annotation.mustBeViewedWhenEditing()) ||
(!isEditing && !modifiedIds?.has(annotation.data.id)))) ||
annotation.mustBeViewedWhenEditing(isEditing, modifiedIds)) ||
(intentPrint && annotation.mustBePrinted(annotationStorage))
) {
opListPromises.push(