mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-26 10:08:06 +02:00
XFA - Fix text positions (bug 1718741)
- font line height is taken into account by acrobat when it isn't with masterpdfeditor: I extracted a font from a pdf, modified some ascent/descent properties thanks to ttx and the reinjected the font in the pdf: only Acrobat is taken it into account. So in this patch, line heights for some substituted fonts are added. - it seems that Acrobat is using a line height of 1.2 when the line height in the font is not enough (it's the only way I found to fix correctly bug 1718741). - don't use flex in wrapper container (which was causing an horizontal overflow in the above bug). - consequently, the above fixes introduced a lot of small regressions, so in order to see real improvements on reftests, I fixed the regressions in this patch: - replace margin by padding in some case where padding is a part of a container dimensions; - remove some flex display: some containers are wrongly sized when rendered; - set letter-spacing to 0.01px: it helps to be sure that text is not broken because of not enough width in Firefox.
This commit is contained in:
parent
0afc785c7d
commit
58e1f51688
15 changed files with 220 additions and 103 deletions
|
@ -81,6 +81,7 @@ const SegoeuiBoldFactors = [
|
|||
1.02511, 0.99298, 1.07237, 0.96752, 0.96752, 0.96752, 0.96752, 1.03424,
|
||||
0.96752, 0.95801, 0.95801, 0.95801, 0.95801, 1.03424, 1.0106,
|
||||
];
|
||||
const SegoeuiBoldLineHeight = 1.33008;
|
||||
|
||||
// Factors to rescale LiberationSans-BoldItalic.ttf to have the same
|
||||
// metrics as segoeuiz.ttf.
|
||||
|
@ -151,6 +152,7 @@ const SegoeuiBoldItalicFactors = [
|
|||
0.96752, 0.96752, 1.036, 0.96752, 0.97168, 0.97168, 0.97168, 0.97168, 1.036,
|
||||
0.95134,
|
||||
];
|
||||
const SegoeuiBoldItalicLineHeight = 1.33008;
|
||||
|
||||
// Factors to rescale LiberationSans-Italic.ttf to have the same
|
||||
// metrics as segoeuii.ttf.
|
||||
|
@ -221,6 +223,7 @@ const SegoeuiItalicFactors = [
|
|||
0.96777, 0.96777, 0.96777, 0.96927, 0.96777, 0.9043, 0.9043, 0.9043, 0.9043,
|
||||
0.96927, 0.95364,
|
||||
];
|
||||
const SegoeuiItalicLineHeight = 1.33008;
|
||||
|
||||
// Factors to rescale LiberationSans-Regular.ttf to have the same
|
||||
// metrics as segoeui.ttf.
|
||||
|
@ -291,10 +294,15 @@ const SegoeuiRegularFactors = [
|
|||
1.00068, 0.91797, 0.99346, 0.96777, 0.96777, 0.96777, 0.96777, 0.96927,
|
||||
0.96777, 0.9043, 0.9043, 0.9043, 0.9043, 0.96927, 1.00221,
|
||||
];
|
||||
const SegoeuiRegularLineHeight = 1.33008;
|
||||
|
||||
export {
|
||||
SegoeuiBoldFactors,
|
||||
SegoeuiBoldItalicFactors,
|
||||
SegoeuiBoldItalicLineHeight,
|
||||
SegoeuiBoldLineHeight,
|
||||
SegoeuiItalicFactors,
|
||||
SegoeuiItalicLineHeight,
|
||||
SegoeuiRegularFactors,
|
||||
SegoeuiRegularLineHeight,
|
||||
};
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue