1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-25 09:38:06 +02:00

Prefer instanceof Dict rather than calling isDict() with one argument

Unless you actually need to check that something is both a `Dict` and also of the *correct* type, using `instanceof Dict` directly should be a tiny bit more efficient since it avoids one function call and an unnecessary `undefined` check.

This patch uses ESLint to enforce this, since we obviously still want to keep the `isDict` helper function for where it makes sense.
This commit is contained in:
Jonas Jenwald 2022-02-21 12:44:56 +01:00
parent 67b658e8d5
commit 4df82ad31e
18 changed files with 83 additions and 93 deletions

View file

@ -22,16 +22,7 @@ import {
StreamType,
warn,
} from "../shared/util.js";
import {
Cmd,
Dict,
EOF,
isCmd,
isDict,
isName,
Name,
Ref,
} from "./primitives.js";
import { Cmd, Dict, EOF, isCmd, isName, Name, Ref } from "./primitives.js";
import {
isWhiteSpace,
MissingDataException,
@ -1401,7 +1392,7 @@ class Linearization {
Number.isInteger(obj1) &&
Number.isInteger(obj2) &&
isCmd(obj3, "obj") &&
isDict(linDict) &&
linDict instanceof Dict &&
isNum((obj = linDict.get("Linearized"))) &&
obj > 0
)