mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-25 09:38:06 +02:00
Code Activity

Prefer instanceof Dict rather than calling isDict() with one argument

Browse source 
Unless you actually need to check that something is both a `Dict` and also of the *correct* type, using `instanceof Dict` directly should be a tiny bit more efficient since it avoids one function call and an unnecessary `undefined` check.

This patch uses ESLint to enforce this, since we obviously still want to keep the `isDict` helper function for where it makes sense.
This commit is contained in:
Jonas Jenwald 2022-02-21 12:44:56 +01:00
parent 67b658e8d5
commit 4df82ad31e
18 changed files with 83 additions and 93 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/core/function.js
View file

@ -13,7 +13,7 @@
* limitations under the License.
*/
import { Dict, isDict, Ref } from "./primitives.js";
import { Dict, Ref } from "./primitives.js";
import {
FormatError,
info,
@ -508,7 +508,7 @@ function isPDFFunction(v) {
let fnDict;
if (typeof v !== "object") {
return false;
} else if (isDict(v)) {
} else if (v instanceof Dict) {
fnDict = v;
} else if (v instanceof BaseStream) {
fnDict = v.dict;