mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-25 09:38:06 +02:00
Code Activity

Prefer instanceof Dict rather than calling isDict() with one argument

Browse source 
Unless you actually need to check that something is both a `Dict` and also of the *correct* type, using `instanceof Dict` directly should be a tiny bit more efficient since it avoids one function call and an unnecessary `undefined` check.

This patch uses ESLint to enforce this, since we obviously still want to keep the `isDict` helper function for where it makes sense.
This commit is contained in:
Jonas Jenwald 2022-02-21 12:44:56 +01:00
parent 67b658e8d5
commit 4df82ad31e
18 changed files with 83 additions and 93 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/core/file_spec.js
View file

@ -15,7 +15,7 @@
import { stringToPDFString, warn } from "../shared/util.js";
import { BaseStream } from "./base_stream.js";
import { isDict } from "./primitives.js";
import { Dict } from "./primitives.js";
function pickPlatformItem(dict) {
// Look for the filename in this order:
@ -43,7 +43,7 @@ function pickPlatformItem(dict) {
*/
class FileSpec {
constructor(root, xref) {
if (!root || !isDict(root)) {
if (!(root instanceof Dict)) {
return;
}
this.xref = xref;