mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Enable the unicorn/prefer-modern-dom-apis ESLint plugin rule

Browse source 
This rule will help enforce slightly shorter code, and according to MDN both `Element.replaceWith()` and `Element.before()` are available in all browsers that we currently support.

Please find additional information here:
 - https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-modern-dom-apis.md
 - https://developer.mozilla.org/en-US/docs/Web/API/Element/replaceWith
 - https://developer.mozilla.org/en-US/docs/Web/API/Element/before
This commit is contained in:
Jonas Jenwald 2022-06-12 17:19:32 +02:00
parent 0c65926d5b
commit 4d39898823
4 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
web/pdf_page_view.js
View file

@ -627,7 +627,7 @@ class PDFPageView {
if (lastDivBeforeTextDiv) {
// The annotation layer needs to stay on top.
div.insertBefore(canvasWrapper, lastDivBeforeTextDiv);
lastDivBeforeTextDiv.before(canvasWrapper);
} else {
div.append(canvasWrapper);
}
@ -640,7 +640,7 @@ class PDFPageView {
textLayerDiv.style.height = canvasWrapper.style.height;
if (lastDivBeforeTextDiv) {
// The annotation layer needs to stay on top.
div.insertBefore(textLayerDiv, lastDivBeforeTextDiv);
lastDivBeforeTextDiv.before(textLayerDiv);
} else {
div.append(textLayerDiv);
}