mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-23 08:38:06 +02:00
Code Activity

Improve clean-up of #_hcmCache-data in DOMFilterFactory.prototype.destroy

Browse source 
- Use optional chaining when clearing various data-structures, since that's slightly shorter.

 - Ensure that checking for the existence of `#_hcmCache`-data won't cause it to be initialized. (Note how `this.#hcmCache` is actually a getter.)

 - Actually reset the `#_hcmCache`-data when that's appropriate, e.g. when closing the PDF document.
This commit is contained in:
Jonas Jenwald 2024-11-17 15:31:42 +01:00
parent bc91985941
commit 4c57ec4da7
1 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/display/filter_factory.js
View file

@ -423,17 +423,18 @@ class DOMFilterFactory extends BaseFilterFactory {
}
destroy(keepHCM = false) {
if (keepHCM && this.#hcmCache.size !== 0) {
if (keepHCM && this.#_hcmCache?.size) {
return;
}
if (this.#_defs) {
this.#_defs.parentNode.parentNode.remove();
this.#_defs = null;
}
if (this.#_cache) {
this.#_cache.clear();
this.#_cache = null;
}
this.#_defs?.parentNode.parentNode.remove();
this.#_defs = null;
this.#_cache?.clear();
this.#_cache = null;
this.#_hcmCache?.clear();
this.#_hcmCache = null;
this.#id = 0;
}