From 48f4580991bda3b2f9756d768a436151bc5c2cb2 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 14 Feb 2021 12:32:50 +0100 Subject: [PATCH] A couple of small `BaseViewer` tweaks - Mark `BaseViewer.initializeScriptingEvents` as an `async` method, since that's actually how it's being used in the default viewer (see `PDFViewerApplication-_initializeJavaScript`). - Change `BaseViewer._pageWidthScaleFactor` to access the *internal* scroll/spread-modes directly, rather than using the getters, since that's consistent with the rest of the code (and not just for these properties). --- web/base_viewer.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/base_viewer.js b/web/base_viewer.js index 3c6f169f5..4ffd54e4c 100644 --- a/web/base_viewer.js +++ b/web/base_viewer.js @@ -740,8 +740,8 @@ class BaseViewer { */ get _pageWidthScaleFactor() { if ( - this.spreadMode !== SpreadMode.NONE && - this.scrollMode !== ScrollMode.HORIZONTAL && + this._spreadMode !== SpreadMode.NONE && + this._scrollMode !== ScrollMode.HORIZONTAL && !this.isInPresentationMode ) { return 2; @@ -1642,7 +1642,7 @@ class BaseViewer { return true; } - initializeScriptingEvents() { + async initializeScriptingEvents() { if (!this.enableScripting || this._pageOpenPendingSet) { return; }