From 47bf12cbac1005f6e4940b5c51a93f0acb7d74a9 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 2 Sep 2018 13:06:28 +0200 Subject: [PATCH] Change `JpegImage._isColorConversionNeeded` into a getter, rather than a regular function Given how `_isColorConversionNeeded` is used, and that it always returns a boolean value, having it be a getter seems more appropriate. --- src/core/jpg.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/jpg.js b/src/core/jpg.js index b85e1d0ed..a08e86ae3 100644 --- a/src/core/jpg.js +++ b/src/core/jpg.js @@ -1024,7 +1024,7 @@ var JpegImage = (function JpegImageClosure() { return data; }, - _isColorConversionNeeded() { + get _isColorConversionNeeded() { if (this.adobe) { // The adobe transform marker overrides any previous setting. return !!this.adobe.transformCode; @@ -1180,10 +1180,10 @@ var JpegImage = (function JpegImageClosure() { rgbData[offset++] = grayColor; } return rgbData; - } else if (this.numComponents === 3 && this._isColorConversionNeeded()) { + } else if (this.numComponents === 3 && this._isColorConversionNeeded) { return this._convertYccToRgb(data); } else if (this.numComponents === 4) { - if (this._isColorConversionNeeded()) { + if (this._isColorConversionNeeded) { if (forceRGBoutput) { return this._convertYcckToRgb(data); }