From 473ea1f1a46a61415aabb7be9c6e4e916ef5652d Mon Sep 17 00:00:00 2001 From: Takashi Tamura Date: Sat, 11 Jul 2020 14:11:36 +0900 Subject: [PATCH] Make the detection of Node.js environments on Electron strict. The main process and its child processes should be detected as Node.js environments. --- src/shared/is_node.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/shared/is_node.js b/src/shared/is_node.js index 95b531429..62fc25b71 100644 --- a/src/shared/is_node.js +++ b/src/shared/is_node.js @@ -16,11 +16,12 @@ // NW.js / Electron is a browser context, but copies some Node.js objects; see // http://docs.nwjs.io/en/latest/For%20Users/Advanced/JavaScript%20Contexts%20in%20NW.js/#access-nodejs-and-nwjs-api-in-browser-context -// https://electronjs.org/docs/api/process#processversionselectron +// https://www.electronjs.org/docs/api/process#processversionselectron-readonly +// https://www.electronjs.org/docs/api/process#processtype-readonly const isNodeJS = typeof process === "object" && process + "" === "[object process]" && !process.versions.nw && - !process.versions.electron; + !(process.versions.electron && process.type && process.type !== "browser"); export { isNodeJS };