From 45ce3a057ff083123de3ff37691e0704e0e44ee0 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Sun, 21 Jul 2024 10:10:23 +0200
Subject: [PATCH] Use shorter local variable names in a few AppOptions methods

Besides being slightly shorter, this should help reduce the risk of confusion given the very similar global Object/Map names.
---
 web/app_options.js | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/web/app_options.js b/web/app_options.js
index 962cac375..0450d163d 100644
--- a/web/app_options.js
+++ b/web/app_options.js
@@ -506,23 +506,23 @@ class AppOptions {
   static getAll(kind = null, defaultOnly = false) {
     const options = Object.create(null);
     for (const name in defaultOptions) {
-      const defaultOption = defaultOptions[name];
+      const defaultOpt = defaultOptions[name];
 
-      if (kind && !(kind & defaultOption.kind)) {
+      if (kind && !(kind & defaultOpt.kind)) {
         continue;
       }
       options[name] =
         !defaultOnly && userOptions.has(name)
           ? userOptions.get(name)
-          : defaultOption.value;
+          : defaultOpt.value;
     }
     return options;
   }
 
   static set(name, value) {
-    const defaultOption = defaultOptions[name];
+    const defaultOpt = defaultOptions[name];
 
-    if (!defaultOption || typeof value !== typeof defaultOption.value) {
+    if (!defaultOpt || typeof value !== typeof defaultOpt.value) {
       return;
     }
     userOptions.set(name, value);
@@ -532,23 +532,23 @@ class AppOptions {
     let events;
 
     for (const name in options) {
-      const defaultOption = defaultOptions[name],
-        userOption = options[name];
+      const defaultOpt = defaultOptions[name],
+        userOpt = options[name];
 
-      if (!defaultOption || typeof userOption !== typeof defaultOption.value) {
+      if (!defaultOpt || typeof userOpt !== typeof defaultOpt.value) {
         continue;
       }
       if (prefs) {
-        const { kind } = defaultOption;
+        const { kind } = defaultOpt;
 
         if (!(kind & OptionKind.BROWSER || kind & OptionKind.PREFERENCE)) {
           continue;
         }
         if (this.eventBus && kind & OptionKind.EVENT_DISPATCH) {
-          (events ||= new Map()).set(name, userOption);
+          (events ||= new Map()).set(name, userOpt);
         }
       }
-      userOptions.set(name, userOption);
+      userOptions.set(name, userOpt);
     }
 
     if (events) {