From 4078dd856c6108eb29b7774d28c5bbaee47e8b6c Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 24 Apr 2021 12:52:09 +0200 Subject: [PATCH] Clear some Arrays, rather than re-initialize them, in `src/display/`-code It's generally better to re-use the same Array, by clearing out all of its elements, rather than creating a new Array. --- src/display/network.js | 12 ++++++------ src/display/transport_stream.js | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/display/network.js b/src/display/network.js index e415a419b..a2f4642d1 100644 --- a/src/display/network.js +++ b/src/display/network.js @@ -350,7 +350,7 @@ class PDFNetworkStreamFullRequestReader { for (const requestCapability of this._requests) { requestCapability.resolve({ value: undefined, done: true }); } - this._requests = []; + this._requests.length = 0; } _onError(status) { @@ -361,8 +361,8 @@ class PDFNetworkStreamFullRequestReader { for (const requestCapability of this._requests) { requestCapability.reject(exception); } - this._requests = []; - this._cachedChunks = []; + this._requests.length = 0; + this._cachedChunks.length = 0; } _onProgress(data) { @@ -416,7 +416,7 @@ class PDFNetworkStreamFullRequestReader { for (const requestCapability of this._requests) { requestCapability.resolve({ value: undefined, done: true }); } - this._requests = []; + this._requests.length = 0; if (this._manager.isPendingRequest(this._fullRequestId)) { this._manager.abortRequest(this._fullRequestId); } @@ -459,7 +459,7 @@ class PDFNetworkStreamRangeRequestReader { for (const requestCapability of this._requests) { requestCapability.resolve({ value: undefined, done: true }); } - this._requests = []; + this._requests.length = 0; this._close(); } @@ -494,7 +494,7 @@ class PDFNetworkStreamRangeRequestReader { for (const requestCapability of this._requests) { requestCapability.resolve({ value: undefined, done: true }); } - this._requests = []; + this._requests.length = 0; if (this._manager.isPendingRequest(this._requestId)) { this._manager.abortRequest(this._requestId); } diff --git a/src/display/transport_stream.js b/src/display/transport_stream.js index 5659d496c..980cfa36a 100644 --- a/src/display/transport_stream.js +++ b/src/display/transport_stream.js @@ -230,7 +230,7 @@ class PDFDataTransportStreamReader { for (const requestCapability of this._requests) { requestCapability.resolve({ value: undefined, done: true }); } - this._requests = []; + this._requests.length = 0; } progressiveDone() { @@ -266,7 +266,7 @@ class PDFDataTransportStreamRangeReader { for (const requestCapability of this._requests) { requestCapability.resolve({ value: undefined, done: true }); } - this._requests = []; + this._requests.length = 0; } this._done = true; this._stream._removeRangeReader(this); @@ -295,7 +295,7 @@ class PDFDataTransportStreamRangeReader { for (const requestCapability of this._requests) { requestCapability.resolve({ value: undefined, done: true }); } - this._requests = []; + this._requests.length = 0; this._stream._removeRangeReader(this); } }