From 07a8836ab200ad1eee83feb3859d8023c191f9f9 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Fri, 29 Mar 2024 22:36:02 +0100
Subject: [PATCH] Ensure that Mesh /Shadings have non-zero width/height (issue
 17848)

---
 src/core/evaluator.js    |  48 ++++++++++++++++++++++++++++-----------
 src/core/pattern.js      |   9 +++++++-
 test/pdfs/.gitignore     |   1 +
 test/pdfs/issue17848.pdf | Bin 0 -> 1033 bytes
 test/test_manifest.json  |   7 ++++++
 5 files changed, 51 insertions(+), 14 deletions(-)
 create mode 100644 test/pdfs/issue17848.pdf

diff --git a/src/core/evaluator.js b/src/core/evaluator.js
index 9d5ad52db..5680ed572 100644
--- a/src/core/evaluator.js
+++ b/src/core/evaluator.js
@@ -1472,26 +1472,43 @@ class PartialEvaluator {
     // Shadings and patterns may be referenced by the same name but the resource
     // dictionary could be different so we can't use the name for the cache key.
     let id = localShadingPatternCache.get(shading);
-    if (!id) {
-      var shadingFill = Pattern.parseShading(
+    if (id) {
+      return id;
+    }
+    let patternIR;
+
+    try {
+      const shadingFill = Pattern.parseShading(
         shading,
         this.xref,
         resources,
         this._pdfFunctionFactory,
         localColorSpaceCache
       );
-      const patternIR = shadingFill.getIR();
-      id = `pattern_${this.idFactory.createObjId()}`;
-      if (this.parsingType3Font) {
-        id = `${this.idFactory.getDocId()}_type3_${id}`;
+      patternIR = shadingFill.getIR();
+    } catch (reason) {
+      if (reason instanceof AbortException) {
+        return null;
       }
-      localShadingPatternCache.set(shading, id);
+      if (this.options.ignoreErrors) {
+        warn(`parseShading - ignoring shading: "${reason}".`);
 
-      if (this.parsingType3Font) {
-        this.handler.send("commonobj", [id, "Pattern", patternIR]);
-      } else {
-        this.handler.send("obj", [id, this.pageIndex, "Pattern", patternIR]);
+        localShadingPatternCache.set(shading, null);
+        return null;
       }
+      throw reason;
+    }
+
+    id = `pattern_${this.idFactory.createObjId()}`;
+    if (this.parsingType3Font) {
+      id = `${this.idFactory.getDocId()}_type3_${id}`;
+    }
+    localShadingPatternCache.set(shading, id);
+
+    if (this.parsingType3Font) {
+      this.handler.send("commonobj", [id, "Pattern", patternIR]);
+    } else {
+      this.handler.send("obj", [id, this.pageIndex, "Pattern", patternIR]);
     }
     return id;
   }
@@ -1551,14 +1568,16 @@ class PartialEvaluator {
           );
         } else if (typeNum === PatternType.SHADING) {
           const shading = dict.get("Shading");
-          const matrix = dict.getArray("Matrix");
           const objId = this.parseShading({
             shading,
             resources,
             localColorSpaceCache,
             localShadingPatternCache,
           });
-          operatorList.addOp(fn, ["Shading", objId, matrix]);
+          if (objId) {
+            const matrix = dict.getArray("Matrix");
+            operatorList.addOp(fn, ["Shading", objId, matrix]);
+          }
           return undefined;
         }
         throw new FormatError(`Unknown PatternType: ${typeNum}`);
@@ -2109,6 +2128,9 @@ class PartialEvaluator {
               localColorSpaceCache,
               localShadingPatternCache,
             });
+            if (!patternId) {
+              continue;
+            }
             args = [patternId];
             fn = OPS.shadingFill;
             break;
diff --git a/src/core/pattern.js b/src/core/pattern.js
index a3fd8db5b..d5acbb425 100644
--- a/src/core/pattern.js
+++ b/src/core/pattern.js
@@ -956,13 +956,20 @@ class MeshShading extends BaseShading {
   }
 
   getIR() {
+    const { bounds } = this;
+    // Ensure that the shading has non-zero width and height, to prevent errors
+    // in `pattern_helper.js` (fixes issue17848.pdf).
+    if (bounds[2] - bounds[0] === 0 || bounds[3] - bounds[1] === 0) {
+      throw new FormatError(`Invalid MeshShading bounds: [${bounds}].`);
+    }
+
     return [
       "Mesh",
       this.shadingType,
       this.coords,
       this.colors,
       this.figures,
-      this.bounds,
+      bounds,
       this.bbox,
       this.background,
     ];
diff --git a/test/pdfs/.gitignore b/test/pdfs/.gitignore
index 29b737b57..0fcd81388 100644
--- a/test/pdfs/.gitignore
+++ b/test/pdfs/.gitignore
@@ -462,6 +462,7 @@
 !issue15716.pdf
 !bug1671312_reduced.pdf
 !bug1671312_ArialNarrow.pdf
+!issue17848.pdf
 !issue6108.pdf
 !issue6113.pdf
 !openoffice.pdf
diff --git a/test/pdfs/issue17848.pdf b/test/pdfs/issue17848.pdf
new file mode 100644
index 0000000000000000000000000000000000000000..65522d539b7c2d8828e14e15050ef8e9eff8d9e6
GIT binary patch
literal 1033
zcmZWo&5ja55H=o6wv&x#Z*?Kj!){N*@Uscw0PJX@W(iE<f$X7|DPYVnO?sLQ`UJj(
zUOaj74Gg}8PvXIYRn0I<mQE&2)qG#oS6>&k(J;DDmrB%j-*-QM{}4h!0Osza0O)o>
z#-G**a-f~g%z|=s<VY{DfI8vEl<D;Z<_R+dryf&1xFo(!lLDp<Cf=5*f!X8^R2jX;
zB-MShg=s*bMi77sLxvtTVS3f%AdtK4Yp^_vRP&(EOCDokHg<+Z3G%Z=CU=LJQ9N%{
zO5u2a9$a{gF9CA0xpUqoHtU2>DB0HqGMnV4D=aR?W~KAv)?A8aEGw4L*%?tMOP!?o
z!i$?M18A~)N7#xb2h@NDFCb(H)jBebQ<Z7*9p($SgjSm&g|nzv1n<YbKXnYCSnl5=
z1*!w_+(&#TapGTJzQHUr@WI$Dc?B_V%XQ3qP*yu^1gqt~-L8;BoS6h+S`QTPqk^l}
zWuspG(q$9cKes|gY39(<g=E^{o+=K)RY%aYnX!|#p3!;^@jjj5_;p{%e(H)5T4F7L
zP^Ei*i^J;cz^v9L=OrOX$ru=8$!KZ@^-xs4oQv(B+27~SZoc;L*Y4?)FW+ALJ3pOs
zYjG|DXo;XY&}udtO_)QKBPab=$RBd;_DN2)PjO-A6xRxla?a{BLreES`wDVw4E?Lf
ePTm7Pa*}>V(&x9LaN0UAxzo53wc7PfB>n>hBmR8=

literal 0
HcmV?d00001

diff --git a/test/test_manifest.json b/test/test_manifest.json
index 3fd5ba0c5..f15a611a3 100644
--- a/test/test_manifest.json
+++ b/test/test_manifest.json
@@ -2562,6 +2562,13 @@
     "link": false,
     "type": "eq"
   },
+  {
+    "id": "issue17848",
+    "file": "pdfs/issue17848.pdf",
+    "md5": "9a5b7ee97e1e03ad506115f15f9b57af",
+    "rounds": 1,
+    "type": "eq"
+  },
   {
     "id": "personwithdog",
     "file": "pdfs/personwithdog.pdf",