mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-22 16:18:08 +02:00
Code Activity

Fallback to check all pages when getting the pageIndex of FieldObjects

Browse source 
Given that the FieldObjects are parsed in parallel, in combination with the existing caching in the `getPage`-method and `annotations`-getter, adding additional caches for this fallback code-path doesn't seem entirely necessary.
This commit is contained in:
Jonas Jenwald 2023-08-10 11:59:40 +02:00
parent 4be6c90796
commit 389a26c115
2 changed files with 66 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

38
src/core/annotation.js
View file

@ -26,6 +26,7 @@ import {
FeatureTest,
getModificationDate,
IDENTITY_MATRIX,
info,
LINE_DESCENT_FACTOR,
LINE_FACTOR,
OPS,
@ -52,7 +53,7 @@ import {
parseAppearanceStream,
parseDefaultAppearance,
} from "./default_appearance.js";
import { Dict, isName, Name, Ref, RefSet } from "./primitives.js";
import { Dict, isName, isRefsEqual, Name, Ref, RefSet } from "./primitives.js";
import { Stream, StringStream } from "./stream.js";
import { writeDict, writeObject } from "./writer.js";
import { BaseStream } from "./base_stream.js";
@ -245,17 +246,38 @@ class AnnotationFactory {
return -1;
}
const pageRef = annotDict.getRaw("P");
if (!(pageRef instanceof Ref)) {
return -1;
if (pageRef instanceof Ref) {
try {
const pageIndex = await pdfManager.ensureCatalog("getPageIndex", [
pageRef,
]);
return pageIndex;
} catch (ex) {
info(`_getPageIndex -- not a valid page reference: "${ex}".`);
}
}
if (annotDict.has("Kids")) {
return -1; // Not an annotation reference.
}
// Fallback to, potentially, checking the annotations of all pages.
// PLEASE NOTE: This could force the *entire* PDF document to load,
// hence it absolutely cannot be done unconditionally.
const numPages = await pdfManager.ensureDoc("numPages");
for (let pageIndex = 0; pageIndex < numPages; pageIndex++) {
const page = await pdfManager.getPage(pageIndex);
const annotations = await pdfManager.ensure(page, "annotations");
for (const annotRef of annotations) {
if (annotRef instanceof Ref && isRefsEqual(annotRef, ref)) {
return pageIndex;
}
}
}
const pageIndex = await pdfManager.ensureCatalog("getPageIndex", [
pageRef,
]);
return pageIndex;
} catch (ex) {
warn(`_getPageIndex: "${ex}".`);
return -1;
}
return -1;
}
static generateImages(annotations, xref, isOffscreenCanvasSupported) {