mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-20 15:18:08 +02:00
Code Activity

Fix the "must check that invisible fields are made visible" scripting integration test

Browse source 
We should not wait for an arbitrary amount of time, which can easily
cause intermittent failures, but wait for a property value change
instead. Note that this patch mirrors the approach we already use in
other scripting integration tests that also check for a visibility
change; see e.g. the "must show a text field and then make in invisible
when content is removed" test.
This commit is contained in:
Tim van der Meij 2024-04-14 18:49:31 +02:00
parent e08de772ff
commit 2e9bd496ce
No known key found for this signature in database
GPG key ID: 8C3FD2925A5F2762
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/integration/scripting_spec.mjs
View file

@ -2104,9 +2104,10 @@ describe("Interaction", () => {
expect(visibility).withContext(`In ${browserName}`).toEqual("hidden");
await page.click(getSelector("11R"));
// eslint-disable-next-line no-restricted-syntax
await waitForTimeout(10);
await page.waitForFunction(
`${getComputedStyleSelector("7R")}.visibility !== "hidden"`
);
visibility = await page.$eval(
getSelector("7R"),
el => getComputedStyle(el).visibility
@ -2115,6 +2116,9 @@ describe("Interaction", () => {
.withContext(`In ${browserName}`)
.toEqual("visible");
await page.waitForFunction(
`${getComputedStyleSelector("8R")}.visibility !== "hidden"`
);
visibility = await page.$eval(
getSelector("8R"),
el => getComputedStyle(el).visibility