1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-26 10:08:06 +02:00

Fix the "copy/paste from a tab to an other" stamp editor integration test

This integration test contains three issues:

- The `page.bringToFront()` call is not awaited, even though it returns
  a promise (see https://pptr.dev/api/puppeteer.page.bringtofront). Note
  that in other tests we do this correctly already.
- The `page.waitForSelector()` call at the end is unnecessary because
  that exact condition is already checked at the end of the
  `waitForImage` function we call just before this line; see
  https://github.com/mozilla/pdf.js/blob/master/test/integration/stamp_editor_spec.mjs#L74.
- The pages should be closed in reversed order; please refer to the
  description in #18318 for more details.

Fixes #18318.
This commit is contained in:
Tim van der Meij 2024-06-23 18:26:23 +02:00
parent b4393a7e79
commit 287fd6afd4
No known key found for this signature in database
GPG key ID: 8C3FD2925A5F2762

View file

@ -559,27 +559,30 @@ describe("Stamp Editor", () => {
});
afterAll(async () => {
await closePages(pages1);
// Close the pages in reverse order because the second document will have
// focus at the end of the test and the `testingClose` method requires
// (via `requestAnimationFrame` usage in the `this.l10n.destroy()` call)
// that the page it's called on has focus.
await closePages(pages2);
await closePages(pages1);
});
it("must check that the alt-text button is here when pasting in the second tab", async () => {
for (let i = 0; i < pages1.length; i++) {
const [, page1] = pages1[i];
page1.bringToFront();
await page1.bringToFront();
await page1.click("#editorStamp");
await copyImage(page1, "../images/firefox_logo.png", 0);
await kbCopy(page1);
const [, page2] = pages2[i];
page2.bringToFront();
await page2.bringToFront();
await page2.click("#editorStamp");
await kbPaste(page2);
await waitForImage(page2, getEditorSelector(0));
await page2.waitForSelector(`${getEditorSelector(0)} .altText`);
}
});
});