mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-19 22:58:07 +02:00
Code Activity

Fix the "Text selection using mouse doesn't jump when hovering on an empty area in a single page" integration test

Browse source 
The `getSpanRectFromText` helper function returns the location as float
values. This could be desirable in cases where the exact values matter
(for example during comparisons), but in the text layer tests we don't
need this precision. Moreover, the Puppeteer `page.mouse.move` API
apparently doesn't work correctly if float values are given as input.

Note that this test only failed because it couldn't move to the initial
selection position; any subsequent moves actually worked because the
`moveInSteps` helper function already rounded all values correctly.

This commit fixes the issue by consistently rounding all values that we
pass to Puppeteer's `page.mouse.move` API.
This commit is contained in:
Tim van der Meij 2024-10-19 16:38:22 +02:00
parent b94ab46be5
commit 24b8393bfe
No known key found for this signature in database
GPG key ID: 8C3FD2925A5F2762
1 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

14
test/integration/text_layer_spec.mjs
View file

@ -39,17 +39,23 @@ describe("Text layer", () => {
}
function middlePosition(rect) {
return { x: rect.x + rect.width / 2, y: rect.y + rect.height / 2 };
return {
x: Math.round(rect.x + rect.width / 2),
y: Math.round(rect.y + rect.height / 2),
};
}
function middleLeftPosition(rect) {
return { x: rect.x + 1, y: rect.y + Math.floor(rect.height / 2) };
return {
x: Math.round(rect.x + 1),
y: Math.round(rect.y + rect.height / 2),
};
}
function belowEndPosition(rect) {
return {
x: rect.x + rect.width,
y: rect.y + Math.floor(rect.height * 1.5),
x: Math.round(rect.x + rect.width),
y: Math.round(rect.y + rect.height * 1.5),
};
}