mirror of
https://github.com/mozilla/pdf.js.git
synced 2025-04-29 15:47:57 +02:00
Fix inconsistent spacing and trailing commas in objects in web/
files, so we can enable the comma-dangle
and object-curly-spacing
ESLint rules later on
http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in *one* big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. *Please note:* This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/web/pdf_thumbnail_view.js b/web/pdf_thumbnail_view.js index 002dbf29..1de4e530 100644 --- a/web/pdf_thumbnail_view.js +++ b/web/pdf_thumbnail_view.js @@ -420,8 +420,8 @@ var PDFThumbnailView = (function PDFThumbnailViewClosure() { setPageLabel: function PDFThumbnailView_setPageLabel(label) { this.pageLabel = (typeof label === 'string' ? label : null); - this.l10n.get('thumb_page_title', { page: this.pageId, }, 'Page {{page}}'). - then((msg) => { + this.l10n.get('thumb_page_title', { page: this.pageId, }, + 'Page {{page}}').then((msg) => { this.anchor.title = msg; }); diff --git a/web/secondary_toolbar.js b/web/secondary_toolbar.js index 160e0410..6495fc5e 100644 --- a/web/secondary_toolbar.js +++ b/web/secondary_toolbar.js @@ -65,7 +65,8 @@ class SecondaryToolbar { { element: options.printButton, eventName: 'print', close: true, }, { element: options.downloadButton, eventName: 'download', close: true, }, { element: options.viewBookmarkButton, eventName: null, close: true, }, - { element: options.firstPageButton, eventName: 'firstpage', close: true, }, + { element: options.firstPageButton, eventName: 'firstpage', + close: true, }, { element: options.lastPageButton, eventName: 'lastpage', close: true, }, { element: options.pageRotateCwButton, eventName: 'rotatecw', close: false, }, @@ -76,7 +77,7 @@ class SecondaryToolbar { { element: options.cursorHandToolButton, eventName: 'switchcursortool', eventDetails: { tool: CursorTool.HAND, }, close: true, }, { element: options.documentPropertiesButton, - eventName: 'documentproperties', close: true, } + eventName: 'documentproperties', close: true, }, ]; this.items = { firstPage: options.firstPageButton, ```
This commit is contained in:
parent
bb7e85c5ea
commit
223c429357
26 changed files with 125 additions and 124 deletions
|
@ -20,7 +20,7 @@ var FindStates = {
|
|||
FIND_FOUND: 0,
|
||||
FIND_NOTFOUND: 1,
|
||||
FIND_WRAPPED: 2,
|
||||
FIND_PENDING: 3
|
||||
FIND_PENDING: 3,
|
||||
};
|
||||
|
||||
var FIND_SCROLL_OFFSET_TOP = -50;
|
||||
|
@ -70,11 +70,11 @@ var PDFFindController = (function PDFFindControllerClosure() {
|
|||
this.matchCount = 0;
|
||||
this.selected = { // Currently selected match.
|
||||
pageIdx: -1,
|
||||
matchIdx: -1
|
||||
matchIdx: -1,
|
||||
};
|
||||
this.offset = { // Where the find algorithm currently is in the document.
|
||||
pageIdx: null,
|
||||
matchIdx: null
|
||||
matchIdx: null,
|
||||
};
|
||||
this.pagesToSearch = null;
|
||||
this.resumePageIdx = null;
|
||||
|
@ -180,7 +180,7 @@ var PDFFindController = (function PDFFindControllerClosure() {
|
|||
matchesWithLength.push({
|
||||
match: matchIdx,
|
||||
matchLength: subqueryLen,
|
||||
skipped: false
|
||||
skipped: false,
|
||||
});
|
||||
}
|
||||
}
|
||||
|
@ -406,7 +406,7 @@ var PDFFindController = (function PDFFindControllerClosure() {
|
|||
this.selected.pageIdx === pageIndex) {
|
||||
var spot = {
|
||||
top: FIND_SCROLL_OFFSET_TOP,
|
||||
left: FIND_SCROLL_OFFSET_LEFT
|
||||
left: FIND_SCROLL_OFFSET_LEFT,
|
||||
};
|
||||
scrollIntoView(elements[beginIdx], spot,
|
||||
/* skipOverflowHiddenElements = */ true);
|
||||
|
@ -476,7 +476,7 @@ var PDFFindController = (function PDFFindControllerClosure() {
|
|||
if (this.onUpdateState) {
|
||||
this.onUpdateState(state, previous, this.matchCount);
|
||||
}
|
||||
}
|
||||
},
|
||||
};
|
||||
return PDFFindController;
|
||||
})();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue