mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-26 10:08:06 +02:00
Code Activity

Remove variable shadowing from the JavaScript files in the src/core/ folder

Browse source 
*This is part of a series of patches that will try to split PR 11566 into smaller chunks, to make reviewing more feasible.*

Once all the code has been fixed, we'll be able to eventually enable the ESLint no-shadow rule; see https://eslint.org/docs/rules/no-shadow
This commit is contained in:
Jonas Jenwald 2020-03-23 17:04:47 +01:00
parent b86df97725
commit 216cbca16c
11 changed files with 135 additions and 140 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/core/jpg.js
View file

@ -223,10 +223,10 @@ var JpegImage = (function JpegImageClosure() {
return n + (-1 << length) + 1;
}
function decodeBaseline(component, offset) {
function decodeBaseline(component, blockOffset) {
var t = decodeHuffman(component.huffmanTableDC);
var diff = t === 0 ? 0 : receiveAndExtend(t);
component.blockData[offset] = component.pred += diff;
component.blockData[blockOffset] = component.pred += diff;
var k = 1;
while (k < 64) {
var rs = decodeHuffman(component.huffmanTableAC);
@ -241,23 +241,23 @@ var JpegImage = (function JpegImageClosure() {
}
k += r;
var z = dctZigZag[k];
component.blockData[offset + z] = receiveAndExtend(s);
component.blockData[blockOffset + z] = receiveAndExtend(s);
k++;
}
}
function decodeDCFirst(component, offset) {
function decodeDCFirst(component, blockOffset) {
var t = decodeHuffman(component.huffmanTableDC);
var diff = t === 0 ? 0 : receiveAndExtend(t) << successive;
component.blockData[offset] = component.pred += diff;
component.blockData[blockOffset] = component.pred += diff;
}
function decodeDCSuccessive(component, offset) {
component.blockData[offset] |= readBit() << successive;
function decodeDCSuccessive(component, blockOffset) {
component.blockData[blockOffset] |= readBit() << successive;
}
var eobrun = 0;
function decodeACFirst(component, offset) {
function decodeACFirst(component, blockOffset) {
if (eobrun > 0) {
eobrun--;
return;
@ -278,7 +278,7 @@ var JpegImage = (function JpegImageClosure() {
}
k += r;
var z = dctZigZag[k];
component.blockData[offset + z] =
component.blockData[blockOffset + z] =
receiveAndExtend(s) * (1 << successive);
k++;
}
@ -286,14 +286,14 @@ var JpegImage = (function JpegImageClosure() {
var successiveACState = 0,
successiveACNextValue;
function decodeACSuccessive(component, offset) {
function decodeACSuccessive(component, blockOffset) {
var k = spectralStart;
var e = spectralEnd;
var r = 0;
var s;
var rs;
while (k <= e) {
const offsetZ = offset + dctZigZag[k];
const offsetZ = blockOffset + dctZigZag[k];
const sign = component.blockData[offsetZ] < 0 ? -1 : 1;
switch (successiveACState) {
case 0: // initial state
@ -358,15 +358,15 @@ var JpegImage = (function JpegImageClosure() {
var mcuCol = mcu % mcusPerLine;
blockRow = mcuRow * component.v + row;
var blockCol = mcuCol * component.h + col;
var offset = getBlockBufferOffset(component, blockRow, blockCol);
decode(component, offset);
const blockOffset = getBlockBufferOffset(component, blockRow, blockCol);
decode(component, blockOffset);
}
function decodeBlock(component, decode, mcu) {
blockRow = (mcu / component.blocksPerLine) | 0;
var blockCol = mcu % component.blocksPerLine;
var offset = getBlockBufferOffset(component, blockRow, blockCol);
decode(component, offset);
const blockOffset = getBlockBufferOffset(component, blockRow, blockCol);
decode(component, blockOffset);
}
var componentsLength = components.length;