mirrors/pdf.js
1
0
Fork 0
mirror of https://github.com/mozilla/pdf.js.git synced 2025-04-21 07:38:07 +02:00
Code Activity

[api-major] Change getJavaScript to return null, rather than an empty Array, when no JavaScript exists

Browse source 
Other API methods already return `null`, rather than empty Arrays/Objects, hence it makes sense to change `getJavaScript` to be consistent.
This commit is contained in:
Jonas Jenwald 2017-10-15 22:13:58 +02:00
parent 4fdb0f57d7
commit 1cd1582cb9
4 changed files with 16 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/unit/api_spec.js
View file

@ -684,7 +684,7 @@ describe('api', function() {
it('gets javascript', function(done) {
var promise = doc.getJavaScript();
promise.then(function (data) {
expect(data).toEqual([]);
expect(data).toEqual(null);
done();
}).catch(function (reason) {
done.fail(reason);